Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python #24

Merged
merged 4 commits into from
May 4, 2019
Merged

Drop support for EOL Python #24

merged 4 commits into from
May 4, 2019

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 12, 2018

Python 2.6 and 3.3 are EOL (since 2013-10-29 and 2017-09-29 respectively) and no longer receiving security updates (or any updates) from the core Python team.

They're also failing the CI and little used.

Here's the pip installs for lazy-object-proxy from PyPI for August 2018:

python_version percent download_count
3.6 41.63% 916,939
2.7 34.56% 761,109
3.5 11.28% 248,483
3.7 9.22% 203,077
3.4 3.23% 71,081
3.3 0.04% 792
2.6 0.02% 495
3.8 0.02% 390
3.2 0.00% 44
None 0.00% 1
Total 2,202,411

Source: pypinfo --start-date 2018-08-01 --end-date 2018-08-31 --json lazy-object-proxy pyversion

This PR:

  • Drops support for EOL Python 2.6 and 3.3
  • Upgrades Python syntax with pyupgrade https://github.com/asottile/pyupgrade
  • Add python_requires to setup.py to help pip install the right package version
  • Remove pytest-capturelog dependency, as it's been merged into pytest's core

There's still some Coverage-related errors on the CI, but this improves things:

Travis CI before

image

https://travis-ci.org/hugovk/python-lazy-object-proxy/builds/427327283

Travis CI after

image

https://travis-ci.org/hugovk/python-lazy-object-proxy/builds/427371253

AppVeyor before

image

https://ci.appveyor.com/project/hugovk/python-lazy-object-proxy/build/master-3

AppVeyor after

image

https://ci.appveyor.com/project/hugovk/python-lazy-object-proxy/build/rm-eol-6

@codecov-io
Copy link

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files           7        7           
  Lines        2022     2022           
  Branches      282      282           
=======================================
  Hits         1902     1902           
  Misses         97       97           
  Partials       23       23
Impacted Files Coverage Δ
tests/test_lazy_object_proxy.py 92.55% <ø> (ø) ⬆️
src/lazy_object_proxy/slots.py 96.37% <100%> (ø) ⬆️
src/lazy_object_proxy/simple.py 97.45% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39feb11...bcf18b4. Read the comment docs.

@hugovk
Copy link
Contributor Author

hugovk commented Oct 13, 2018

Rebased on master.

@ionelmc ionelmc merged commit bcf18b4 into ionelmc:master May 4, 2019
@hugovk hugovk deleted the rm-eol branch May 5, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants