Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop grunt #446

Merged
merged 8 commits into from
Mar 14, 2021
Merged

Drop grunt #446

merged 8 commits into from
Mar 14, 2021

Conversation

chris34
Copy link
Member

@chris34 chris34 commented Mar 8, 2021

  1. No grunt, just little npm scripts. (as node-dependencies just jshint and less left. That's about 50 npm-packages)
  2. As all sprite were removed, the icons of the Wikieditor were migrated to SVGs.

Part of #424

@chris34 chris34 added enhancement security general dependencies Pull requests that update a dependency file labels Mar 8, 2021
chris34 added 3 commits March 13, 2021 21:06
@chris34
Replace grunt with npm scripts
1d06e54 
 * jshintConfig is updated for new version and deprecated options
   removed
 * jshint is not included in 'npm run all' as the new version raises a
   lot of errors
@chris34
Wikieditor: Use unicode arrows for enlarge and shrink
5cc1a9b
@chris34
Editor: Use SVG icons
c18620e 
If the icon is only used in the editor, the SVG is now
directly inlined in the CSS.
@chris34 chris34 requested review from Lyra2108, sebix and v-gar March 13, 2021 20:20
@sebix
Copy link
Member

sebix commented Mar 13, 2021

Hard for me to review, except to test for "works for me". I can do that, if you also update inyoka/docs/getting_started.rst :P

@chris34
Copy link
Member Author

chris34 commented Mar 13, 2021

I can do that, if you also update inyoka/docs/getting_started.rst

Already a good review. I totally forgot to update it… Updated it now.

F.e. you could also review if the find-commands in package.json need improvements or just see, whether icons in the forum or the Wiki-editor are all displayed fine (as i switched them to SVG).

sebix
sebix approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@sebix sebix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me™

Tested the docs and if the frontend works (in the browser)

@chris34 chris34 merged commit f151b9f into inyokaproject:staging Mar 14, 2021
@chris34 chris34 deleted the drop-grunt branch March 14, 2021 16:20
@chris34 chris34 mentioned this pull request Mar 14, 2021
Merged
chris34 added a commit to inyokaproject/inyoka that referenced this pull request Mar 14, 2021
@chris34
Drop grunt
7eb43df 
After the PR in the theme is merged
inyokaproject/theme-ubuntuusers#446
the inyoka repo needs some changes, too.
Otherwise the CI will not run successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebix sebix sebix approved these changes

@Lyra2108 Lyra2108 Awaiting requested review from Lyra2108

@v-gar v-gar Awaiting requested review from v-gar

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement general security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris34 @sebix