Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(app, secondary-apps): fix links to other modules #5149

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

The raw links to modules do not work but if you add usage to the URL the links should work

Related issues

No issue logged, noticed while troubleshooting #5134

Release Summary

conventional commit message

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Check vercel test build after it renders


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Apr 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/D4mbQxGXKDhmB2Ey7LJsDChSpyLj
✅ Preview: https://react-native-f-git-mikehardy-secondary-apps-links-in-62589d.vercel.app

@mikehardy
Copy link
Collaborator Author

Passes inspection on vercel preview build

@mikehardy mikehardy merged commit 391a9dc into master Apr 10, 2021
@mikehardy mikehardy deleted the @mikehardy/secondary-apps-links branch April 10, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant