Fix (messaging) and signInWithPhoneNumber #3425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NativeFirebaseError: [auth/notification-not-forwarded] If app delegate swizzling is disabled, remote notifications received by UIApplicationDelegate need to be forwarded to FIRAuth's canHandleNotificaton: method.
at FirebaseAuthModule.signInWithPhoneNumber (http://192.168.0.167:8081/index.bundle?platform=ios&dev=true&minify=false:107323:28)
|
|
Codecov Report
@@ Coverage Diff @@
## master #3425 +/- ##
=========================================
Coverage ? 85.25%
=========================================
Files ? 108
Lines ? 3429
Branches ? 0
=========================================
Hits ? 2923
Misses ? 506
Partials ? 0 |
|
This works for me and is already in my production application. |
|
Patch Package to the rescue: https://github.com/ds300/patch-package Do not develop in react-native without it |
Salakar
added
the
blocked: do-not-merge
|
This change needs updating to handle if the Auth package is not in use by the users application - FIRAuth class won't be found in that case and would cause a build failure I can look at this though if needed |
|
what's the best way to do this? |
|
This fix works for me. |
|
Have fixed this in fb70797 with the FIRAuth class existence check Thanks for sending this PR - it was helpful |
|
(a release will be out later today) |
Salakar
added a commit
that referenced
this pull request
Apr 22, 2020
* fix(messaging,ios): keep original UNUserNotificationCenter delegate Keeps a reference to any original UNUserNotificationCenter delegates that are set before we replace the delegate with out own implementation. Internally we will also call the original delegate if our code does not already handle the delegate call. This should keep compatibility with other RN modules that set the delegate. * v6.4.1-alpha.0 * Revert "v6.4.1-alpha.0" This reverts commit b355a86 * feat: automatically register with APNs * docs: typos * fix: forward delegate call to FIRAuth Fixes / supersedes #3425 * fix(messaging): add activity check to getInitialNotification (#3495) * fix(messaging): add activity check to getInitialNotification * fix(messaging): add activity check to getInitialNotification * Update .spellcheck.dict.txt Co-authored-by: Mike Diarmid <[email protected]> Co-authored-by: Elliot Hesp <[email protected]>
andersondanilo
pushed a commit
to vixtech/react-native-firebase
that referenced
this pull request
Nov 9, 2020
…ertase#3427) * fix(messaging,ios): keep original UNUserNotificationCenter delegate Keeps a reference to any original UNUserNotificationCenter delegates that are set before we replace the delegate with out own implementation. Internally we will also call the original delegate if our code does not already handle the delegate call. This should keep compatibility with other RN modules that set the delegate. * v6.4.1-alpha.0 * Revert "v6.4.1-alpha.0" This reverts commit b355a86 * feat: automatically register with APNs * docs: typos * fix: forward delegate call to FIRAuth Fixes / supersedes invertase#3425 * fix(messaging): add activity check to getInitialNotification (invertase#3495) * fix(messaging): add activity check to getInitialNotification * fix(messaging): add activity check to getInitialNotification * Update .spellcheck.dict.txt Co-authored-by: Mike Diarmid <[email protected]> Co-authored-by: Elliot Hesp <[email protected]>
hmhm2292
pushed a commit
to hmhm2292/react-native-firebase
that referenced
this pull request
Jul 13, 2021
…ertase#3427) * fix(messaging,ios): keep original UNUserNotificationCenter delegate Keeps a reference to any original UNUserNotificationCenter delegates that are set before we replace the delegate with out own implementation. Internally we will also call the original delegate if our code does not already handle the delegate call. This should keep compatibility with other RN modules that set the delegate. * v6.4.1-alpha.0 * Revert "v6.4.1-alpha.0" This reverts commit b355a86 * feat: automatically register with APNs * docs: typos * fix: forward delegate call to FIRAuth Fixes / supersedes invertase#3425 * fix(messaging): add activity check to getInitialNotification (invertase#3495) * fix(messaging): add activity check to getInitialNotification * fix(messaging): add activity check to getInitialNotification * Update .spellcheck.dict.txt Co-authored-by: Mike Diarmid <[email protected]> Co-authored-by: Elliot Hesp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when trying to use the phone login. conflicts with notifications
Error:
NativeFirebaseError: [auth/notification-not-forwarded] If app delegate swizzling is disabled, remote notifications received by UIApplicationDelegate need to be forwarded to FIRAuth's canHandleNotificaton: method.
at FirebaseAuthModule.signInWithPhoneNumber (http://192.168.0.167:8081/index.bundle?platform=ios&dev=true&minify=false:107323:28)