Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storage): minor fix #3422

Merged
merged 2 commits into from
Apr 18, 2020
Merged

docs(storage): minor fix #3422

merged 2 commits into from
Apr 18, 2020

Conversation

vaibhavhrt
Copy link
Contributor

replace storage with storage() in example

Summary

Checklist

  • Supports Android
  • Supports iOS
  • e2e tests added or updated in packages/**/e2e
  • Flow types updated
  • Typescript types updated

Test Plan

Release Plan

[DOCS][BUGFIX] [Storage] - Minor fix in doc of cloud storage


Think react-native-firebase is great? Please consider supporting the project with any of the below:

replace storage with storage() in example
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2020

CLA assistant check
All committers have signed the CLA.

@vaibhavhrt
Copy link
Contributor Author

Will check this doc page once more to check if anything else can be fixed and will sign this CLA thing, then will mark this ready for review.

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@7f52366). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3422   +/-   ##
=========================================
  Coverage          ?   85.25%           
=========================================
  Files             ?      108           
  Lines             ?     3429           
  Branches          ?        0           
=========================================
  Hits              ?     2923           
  Misses            ?      506           
  Partials          ?        0           

@vaibhavhrt vaibhavhrt marked this pull request as ready for review April 18, 2020 19:46
@vaibhavhrt
Copy link
Contributor Author

This PR is ready for review now, one test is failing but I don't think it's related to changes I did.

@vaibhavhrt vaibhavhrt closed this Apr 18, 2020
@vaibhavhrt vaibhavhrt reopened this Apr 18, 2020
@vaibhavhrt
Copy link
Contributor Author

opps clicky fingers

@Ehesp Ehesp changed the title Cloud Storage Doc minor fix docs(storage): minor fix Apr 18, 2020
@Ehesp Ehesp merged commit 064c767 into invertase:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants