-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect date-time on android #4053
Labels
type: bug
New bug report
Comments
mikehardy
added a commit
that referenced
this issue
Aug 5, 2020
…t it Fixes #4053 with issue noticed and fix provided by @AidanHost
8 tasks
Fantastic bug report. I went 🤠 and just created a PR based directly on this report, using the web UI 🤞 |
mikehardy
added a commit
that referenced
this issue
Aug 5, 2020
…t it (#4055) Fixes #4053 with issue noticed and fix provided by @AidanHost
should be in the next release and...I'm not 100% but I think it might be set up for semver and auto-launch so, be on the lookout |
androidIsForVivek
pushed a commit
to androidIsForVivek/react-native-firebase
that referenced
this issue
Aug 9, 2021
…t it (invertase#4055) Fixes invertase#4053 with issue noticed and fix provided by @AidanHost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi guys,
sorry, not really setup to create a pull request here, but there is a bug in the SharedUtils.java file
timestamp
is seconds since Epoch https://firebase.google.com/docs/reference/android/com/google/firebase/auth/GetTokenResult#getExpirationTimestamp()react-native-firebase/packages/app/android/src/reactnative/java/io/invertase/firebase/common/SharedUtils.java
Line 101 in 3582e48
the
calendar.getTimeZone().getOffset(timestamp)
call returns milliseconds, so it should be excluded from the* 1000
calculationJava docs: https://docs.oracle.com/javase/7/docs/api/java/util/TimeZone.html#getOffset(long)
The text was updated successfully, but these errors were encountered: