fix(crashlytics, debug): Disable Crashlytics in debug mode by default (…

…#5117) * Update ReactNativeFirebaseCrashlyticsInitProvider.java Disabled crashlytics in debug mode by default. * Update RNFBCrashlyticsInitProvider.m Disabled crashlytics in debug mode by default on iOS. * only alter crashlytics status to disable it, if it was not enabled before in the auto collection settings it should not be enabled now this matches the android implementation Co-authored-by: Waqas Ahmed <[email protected]>
invertase · Apr 4, 2021 · eeeba2e · eeeba2e · vercel · Apr 4, 2021
1 parent c94546d
commit eeeba2e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/...in/java/io/invertase/firebase/crashlytics/ReactNativeFirebaseCrashlyticsInitProvider.java b/...in/java/io/invertase/firebase/crashlytics/ReactNativeFirebaseCrashlyticsInitProvider.java
@@ -42,6 +42,10 @@ static boolean isCrashlyticsCollectionEnabled() {
     } else {
       enabled = meta.getBooleanValue(KEY_CRASHLYTICS_AUTO_COLLECTION_ENABLED, true);
     }
+
+    if (!json.getBooleanValue(KEY_CRASHLYTICS_DEBUG_ENABLED, false) && BuildConfig.DEBUG) {
+      enabled = false;
+    }
 
     return enabled;
   }

diff --git a/packages/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m b/packages/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m
@@ -47,6 +47,13 @@ + (BOOL)isCrashlyticsCollectionEnabled {
     enabled = [RNFBMeta getBooleanValue:KEY_CRASHLYTICS_AUTO_COLLECTION_ENABLED defaultValue:YES];
     DLog(@"isCrashlyticsCollectionEnabled via RNFBMeta: %d", enabled);
   }
+
+#ifdef DEBUG
+  if (![[RNFBJSON shared] getBooleanValue:KEY_CRASHLYTICS_DEBUG_ENABLED defaultValue:NO]) {
+    enabled = NO;
+  }
+  DLog(@"isCrashlyticsCollectionEnabled after checking RNFBJSON %@: %d", KEY_CRASHLYTICS_DEBUG_ENABLED, enabled);
+#endif
 
   DLog(@"isCrashlyticsCollectionEnabled: %d", enabled);