Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all decorators to lowercase #55

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

the-owl
Copy link
Contributor

@the-owl the-owl commented Jul 6, 2017

Renamed all decorators to lowercase according to issue #596

Description

All decorators have been just renamed to lowercase, with the expection of HTTP method decorators - these have been prefixed with http because delete is a reserved word and it cannot be used as an identifier. So new names are httpGet, httpPost, ..., etc.
Also, decorators in unit tests have been renamed and import name of supertest library has been changed from request to supertest to avoid name collision with @request decorator.
Documentation (README.md) has been updated to match new decorator names.

Related Issue

inversify/InversifyJS#596

How Has This Been Tested?

All unit tests pass successfully.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes (because no code has been added).
  • All new and existing tests passed.

@remojansen remojansen merged commit a55234b into inversify:master Jul 6, 2017
@remojansen
Copy link
Member

@the-owl thanks a lot for contributing 👍 I hope you enjoyed it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants