feature/kakfa-config #8421
Merged
feature/kakfa-config #8421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdurand
requested changes
Dec 4, 2024
| sub field_meta { | ||
| my ($self, $field, $parent_meta, $no_array) = @_; | ||
| my $type = $self->field_type($field, $no_array); | ||
| my $meta = { |
| return $allowed_lookup; | ||
| } | ||
|
|
||
| if ($field->isa("pfappserver::Form::Field::FingerbankSelect") || $field->isa("pfappserver::Form::Field::FingerbankField")) { |
There was a problem hiding this comment.
I am surprised to see references of fingerbank in Kafka config , is it normal ?
There was a problem hiding this comment.
This was a copy and paste from Controller::Config.
I need to refactor the shared logic into a seperate module.
This will be done in another release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to config kafka from the GUI
Delete branch after merge
YES
Checklist
(REQUIRED) - [yes, no or n/a]
NEWS file entries
Enhancements