Change useOpenLdap.js to case-insensitive attribute name indices #8366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to case-insensitive attribute name indices, set base_dn for getSubSchemaDN to null, and added explicit limits to sendLdapSearchRequest function calls.
|
|
E-ThanG
changed the title
|
@E-ThanG thank you for your contribution I will need to apply these changes to type=AD as well. |
satkunas
added a commit
that referenced
this pull request
Nov 6, 2024
I considered that, but in my testing AD wasn't case sensitive. In fact, the returned attribute case seemed to change depending on the case of my query. It certainly wouldn't hurt to also have it there though. |
satkunas
pushed a commit
that referenced
this pull request
Nov 6, 2024
Changed to case-insensitive attribute name indices, set base_dn for getSubSchemaDN to null, and added explicit limits to sendLdapSearchRequest function calls.
satkunas
added a commit
that referenced
this pull request
Nov 6, 2024
satkunas
pushed a commit
that referenced
this pull request
Nov 6, 2024
Changed to case-insensitive attribute name indices, set base_dn for getSubSchemaDN to null, and added explicit limits to sendLdapSearchRequest function calls.
satkunas
added a commit
that referenced
this pull request
Nov 6, 2024
satkunas
pushed a commit
that referenced
this pull request
Nov 6, 2024
Changed to case-insensitive attribute name indices, set base_dn for getSubSchemaDN to null, and added explicit limits to sendLdapSearchRequest function calls.
satkunas
added a commit
that referenced
this pull request
Nov 6, 2024
satkunas
pushed a commit
that referenced
this pull request
Nov 6, 2024
Changed to case-insensitive attribute name indices, set base_dn for getSubSchemaDN to null, and added explicit limits to sendLdapSearchRequest function calls.
satkunas
added a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed useOpenLdap.js to case-insensitive attribute name indices, set base_dn for getSubSchemaDN to null, and added explicit limits to sendLdapSearchRequest function calls.
Description
Fixes issue with case mismatch of subSchemaSubEntry, subSchema, and attributeTypes names on various LDAP servers. This resulted in AD LDAP and RedHat Directory389 LDAP (And probably others) not able to use LDAP Authentication Source conditions.
Impacts
AD LDAP and RedHat Directory389 schema download
Delete branch after merge
YES
Checklist
Bug Fixes
Partially fixes #8088 "LDAP Conditions not working for LDAP authentication Source"
There's another unresolved bug that remains for that issue though. see: #8088 (comment)