global: backports Flask-IIIF extension from 2.1 to 2.0

[blixhavn]

No description provided.

[blixhavn]

Added Amended-by as I didn't feel any of the other fits the purpose. Should I change it?

[tiborsimko]

This PR backports a new feature into an already-released maintenance branch. Two general comments: (1) it would be preferred to fix any bugs you spotted in v2.1 so that you could use the latest version instead; (2) if not possible, and you'd need to backport a feature, then it should be optional and not switched on by default, so that other installations aren't affected...

[blixhavn]

1. Unfortunately, there are too many large and critical bugs in 2.1 to make it usable in production. (e.g. search with special characters not working [https://github.com/search: Search is not working with special character.  #3296], facets not working [https://github.com/search: Facet management not working #3333], the collection admin interface is lacking basic functionality)

2. As per our talk, I have removed the addition of flask_iiif to the extensions list to avoid adding features to existing 2.0 installations. In addition, I have now removed Flask-IIIF from pip requirements.

[jirikuncar]

I have now removed Flask-IIIF from pip requirements.

You can add it as optional extra (e.g. iiif).

[jirikuncar]

15: M102 unrecognized bullet/signature

Please use one of our agreed signatures. We should also remove the bullets with label NEW.

[blixhavn]

There, iiif added as optional extra, and commit message fixed.

[jirikuncar]

@blixhavn can you mention sha1 of the "Original commit".

WDYT about following commit message:

* NOTE Backports original commit <sha1>. The extension is not enabled by default in order to avoid ...

[blixhavn]

Looks good. Amended.

[jirikuncar]

Can you please put it before img? We try to keep it sorted. Thanks

[jirikuncar]

After #3338 (comment) and rebase, we can

[jirikuncar]

@blixhavn please finish sentence with a dot.

* NOTE Backports original commit
  <sha1>. The extension is not ...

[jirikuncar]

@blixhavn s/orig\./original/ + rebase

[blixhavn]

original was shortened to allow for the full sha1 within 72 characters. Should write original and add a new line before the sha1?

[jirikuncar]

@blixhavn see #3338 (comment) ;)

[blixhavn]

Which sentence is not finished with dot now?

[jirikuncar]

* NOTE Backports original commit
  213b6f1144734c9ecf425a1bc7b78e56ee5e4e3e.  The extension is not 
  enabled by default in order to avoid feature addition to existing
  minor release.

[jirikuncar]

* NOTE Backports Flask-IIIF extension from original commit ...