BibEdit: fix recID type #2796
Closed
BibEdit: fix recID type #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Various functions working with the recid expect it to be an integer, rather than a string. Signed-off-by: Ludmila Marian <[email protected]>
| @@ -36,7 +36,7 @@ def format_element(bfo, style): | |||
| out = "" | |||
|
|
|||
| user_info = bfo.user_info | |||
| if user_can_edit_record_collection(user_info, bfo.recID): | |||
| if user_can_edit_record_collection(user_info, int(bfo.recID)): | |||
There was a problem hiding this comment.
Shouldn't it be fixed somewhere in BibFormatObject?
egabancho
added a commit
to CERNDocumentServer/invenio
that referenced
this pull request
May 9, 2016
…r-bibedit-fix-recid BibEdit: fix recID type
|
@ludmilamarian is the patch still needed or can we close it? |
|
It is deploy on CDS and is a bug fix, thus I is probably relevant for either |
ludmilamarian
pushed a commit
to CERNDocumentServer/invenio
that referenced
this pull request
Oct 27, 2016
…r-bibedit-fix-recid BibEdit: fix recID type
tiborsimko
pushed a commit
to tiborsimko/invenio
that referenced
this pull request
Nov 24, 2016
* FIX Casts record ID type to integer in record editor formatting element. Various functions working with the record ID expect it to be an integer rather than a string. (PR inveniosoftware#2796) Signed-off-by: Ludmila Marian <[email protected]>
|
Closed by #3728. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an integer, rather than a string.
Signed-off-by: Ludmila Marian [email protected]