-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BibEdit: import data with crossref #3503
Comments
Dear @chokribr what exactly are you typing as string in BibEdit? Note that the field accept only a plain doi such as: "10.1021/acsnano.5b02466", without further prefix. If e.g. I type "doi:10.1021/acsnano.5b02466" then I obtain exactly your same error. |
Dear @kaplun @ludmilamarian doi i introduced , please if there's some hints in order to debug this error let me know |
@kaplun @ludmilamarian @jirikuncar i Think that the problem with password i'm using crossref openurl without password by testing the existance CFG_CROSSREF_PASSWORD variable and adding ":" + i've got the record https://github.com/inveniosoftware/invenio/blob/legacy/modules/miscutil/lib/crossrefutils.py#L69 |
@chokribr you mean without password it works? Could then be a problem of encoding the URL of the request BibEdit does to crossref... |
* Correctly urlencodes the query sent to CrossRef in order to retrieve information about a given DOI. (closes inveniosoftware#3503) Reported-by: Chokri Ben Romdhane <[email protected]> Signed-off-by: Samuele Kaplun <[email protected]>
* Correctly urlencodes the query sent to CrossRef in order to retrieve information about a given DOI. (closes inveniosoftware#3503) Reported-by: Chokri Ben Romdhane <[email protected]> Signed-off-by: Samuele Kaplun <[email protected]>
@kaplun the problem is with ":" if CFG_CROSSREF_PASSWORD is balnk no need to add ":" to the URL or query otherwise we will have the error status 119 http://www.crossref.org/openurl/?pid=USERNAME:&noredirect=tru&id=doi:10.1021/acsnano.5b02466 |
Good point |
@kaplun thanks look at this try chokribr/invenio@45f78bb |
@chokribr I think we should merge our two solutions, because both proper encoding of the request and support for accounts without password are both needed. |
* Correctly urlencodes the query sent to CrossRef in order to retrieve information about a given DOI. (closes inveniosoftware#3503) Co-authored-by: Theodoropoulos Theodoros <[email protected]> Co-authored-by: Chokri Ben Romdhane <[email protected]> Signed-off-by: Samuele Kaplun <[email protected]>
* Correctly urlencodes the query sent to CrossRef in order to retrieve information about a given DOI. (closes inveniosoftware#3503) (closes inveniosoftware#1277) Co-authored-by: Theodoropoulos Theodoros <[email protected]> Co-authored-by: Chokri Ben Romdhane <[email protected]> Signed-off-by: Samuele Kaplun <[email protected]>
* Correctly urlencodes the query sent to CrossRef in order to retrieve information about a given DOI. * Supports querying CrossRef with free account (without password). (closes inveniosoftware#3503) (closes inveniosoftware#1277) Co-authored-by: Theodoropoulos Theodoros <[email protected]> Co-authored-by: Chokri Ben Romdhane <[email protected]> Signed-off-by: Samuele Kaplun <[email protected]>
many thanks sam @kaplun congrat it's a pleasure to find solution with you |
* FIX Correctly urlencodes the query sent to CrossRef in order to retrieve information about a given DOI. * FIX Correctly passes the noredirect flag to CrossRef API. * NEW Supports querying CrossRef with free account (without password). (closes inveniosoftware#3503) (closes inveniosoftware#1277) Co-authored-by: Theodoropoulos Theodoros <[email protected]> Co-authored-by: Chokri Ben Romdhane <[email protected]> Signed-off-by: Samuele Kaplun <[email protected]>
* FIX Correctly URL-encodes the query sent to CrossRef in order to retrieve information about a given DOI. * FIX Correctly passes the noredirect flag to CrossRef API. * BETTER Supports querying CrossRef with free account (without password). (closes inveniosoftware#3503) (closes inveniosoftware#1277) (PR inveniosoftware#3516) Co-authored-by: Theodoropoulos Theodoros <[email protected]> Co-authored-by: Chokri Ben Romdhane <[email protected]> Signed-off-by: Samuele Kaplun <[email protected]>
I try to import data from crossref but always i've got this error "This is not a correct DOI, please correct it "
Note : by entring this URL in the Browser http://www.crossref.org/openurl/?pid=USERNAME&noredirect=tru&id=doi:10.1021/acsnano.5b02466
i've got an XML record
i'm using Invenio v1.2.1
The text was updated successfully, but these errors were encountered: