Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BibEdit: import data with crossref #3503

Closed
chokribr opened this issue Sep 14, 2015 · 10 comments
Closed

BibEdit: import data with crossref #3503

chokribr opened this issue Sep 14, 2015 · 10 comments

Comments

@chokribr
Copy link
Member

I try to import data from crossref but always i've got this error "This is not a correct DOI, please correct it "

Note : by entring this URL in the Browser http://www.crossref.org/openurl/?pid=USERNAME&noredirect=tru&id=doi:10.1021/acsnano.5b02466
i've got an XML record
i'm using Invenio v1.2.1

@jirikuncar jirikuncar added this to the v1.2.2 milestone Sep 14, 2015
@jirikuncar jirikuncar changed the title Import data with crossref Bibedit BibEdit: import data with crossref Sep 14, 2015
@kaplun
Copy link
Member

kaplun commented Sep 14, 2015

Dear @chokribr what exactly are you typing as string in BibEdit? Note that the field accept only a plain doi such as: "10.1021/acsnano.5b02466", without further prefix. If e.g. I type "doi:10.1021/acsnano.5b02466" then I obtain exactly your same error.

@chokribr
Copy link
Member Author

Dear @kaplun @ludmilamarian doi i introduced , please if there's some hints in order to debug this error let me know
doi

@chokribr
Copy link
Member Author

@kaplun @ludmilamarian @jirikuncar i Think that the problem with password i'm using crossref openurl without password by testing the existance CFG_CROSSREF_PASSWORD variable and adding ":" + i've got the record https://github.com/inveniosoftware/invenio/blob/legacy/modules/miscutil/lib/crossrefutils.py#L69
acs

@kaplun
Copy link
Member

kaplun commented Sep 18, 2015

@chokribr you mean without password it works? Could then be a problem of encoding the URL of the request BibEdit does to crossref...

kaplun added a commit to kaplun/invenio that referenced this issue Sep 18, 2015
* Correctly urlencodes the query sent to CrossRef in order to
  retrieve information about a given DOI.
  (closes inveniosoftware#3503)

Reported-by: Chokri Ben Romdhane <[email protected]>
Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio that referenced this issue Sep 18, 2015
* Correctly urlencodes the query sent to CrossRef in order to
  retrieve information about a given DOI.
  (closes inveniosoftware#3503)

Reported-by: Chokri Ben Romdhane <[email protected]>
Signed-off-by: Samuele Kaplun <[email protected]>
@kaplun kaplun assigned kaplun and unassigned jmartinm Sep 18, 2015
@kaplun
Copy link
Member

kaplun commented Sep 18, 2015

@chokribr can you check if the patch in #3516 solves your issue?

@chokribr
Copy link
Member Author

@kaplun the problem is with ":" if CFG_CROSSREF_PASSWORD is balnk no need to add ":" to the URL or query otherwise we will have the error status 119 http://www.crossref.org/openurl/?pid=USERNAME:&noredirect=tru&id=doi:10.1021/acsnano.5b02466

@kaplun
Copy link
Member

kaplun commented Sep 18, 2015

Good point

@chokribr
Copy link
Member Author

@kaplun thanks look at this try chokribr/invenio@45f78bb
and it works

@kaplun
Copy link
Member

kaplun commented Sep 22, 2015

@chokribr I think we should merge our two solutions, because both proper encoding of the request and support for accounts without password are both needed.

@kaplun kaplun reopened this Sep 22, 2015
kaplun added a commit to kaplun/invenio that referenced this issue Sep 22, 2015
* Correctly urlencodes the query sent to CrossRef in order to
  retrieve information about a given DOI.
  (closes inveniosoftware#3503)

Co-authored-by: Theodoropoulos Theodoros <[email protected]>
Co-authored-by: Chokri Ben Romdhane <[email protected]>
Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio that referenced this issue Sep 22, 2015
* Correctly urlencodes the query sent to CrossRef in order to
  retrieve information about a given DOI.
  (closes inveniosoftware#3503) (closes inveniosoftware#1277)

Co-authored-by: Theodoropoulos Theodoros <[email protected]>
Co-authored-by: Chokri Ben Romdhane <[email protected]>
Signed-off-by: Samuele Kaplun <[email protected]>
kaplun added a commit to kaplun/invenio that referenced this issue Sep 22, 2015
* Correctly urlencodes the query sent to CrossRef in order to
  retrieve information about a given DOI.

* Supports querying CrossRef with free account (without
  password).
  (closes inveniosoftware#3503) (closes inveniosoftware#1277)

Co-authored-by: Theodoropoulos Theodoros <[email protected]>
Co-authored-by: Chokri Ben Romdhane <[email protected]>
Signed-off-by: Samuele Kaplun <[email protected]>
@chokribr
Copy link
Member Author

many thanks sam @kaplun congrat it's a pleasure to find solution with you

@chokribr chokribr closed this as completed Nov 3, 2015
kaplun added a commit to kaplun/invenio that referenced this issue Aug 8, 2016
* FIX Correctly urlencodes the query sent to CrossRef in order to
  retrieve information about a given DOI.

* FIX Correctly passes the noredirect flag to CrossRef API.

* NEW Supports querying CrossRef with free account (without
  password).
  (closes inveniosoftware#3503) (closes inveniosoftware#1277)

Co-authored-by: Theodoropoulos Theodoros <[email protected]>
Co-authored-by: Chokri Ben Romdhane <[email protected]>
Signed-off-by: Samuele Kaplun <[email protected]>
tiborsimko pushed a commit to tiborsimko/invenio that referenced this issue Nov 22, 2016
* FIX Correctly URL-encodes the query sent to CrossRef in order
  to retrieve information about a given DOI.

* FIX Correctly passes the noredirect flag to CrossRef API.

* BETTER Supports querying CrossRef with free account
  (without password). (closes inveniosoftware#3503) (closes inveniosoftware#1277) (PR inveniosoftware#3516)

Co-authored-by: Theodoropoulos Theodoros <[email protected]>
Co-authored-by: Chokri Ben Romdhane <[email protected]>
Signed-off-by: Samuele Kaplun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants