Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove future dependency #23

Closed
wants to merge 3 commits into from
Closed

Remove future dependency #23

wants to merge 3 commits into from

Conversation

alanyee
Copy link

@alanyee alanyee commented Sep 30, 2020

Using a thirdparty dependency as big as future for just urlencode() does not seem worth it

@adamchainz
Copy link

Please consider this PR. future triggers a warning on Python 3.8:

  /.../future/standard_library/__init__.py:65: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    import imp

intuit-oauth is the only package in the project I'm looking at that requires future.

It would also make sense to remove Python 2 compatibility altogether, since it was EOL nearly 2 years ago.

jonahgeorge added a commit to jonahgeorge/oauth-pythonclient that referenced this pull request Sep 21, 2023
@uptickmetachu
Copy link

uptickmetachu commented Oct 10, 2023

This is needed for python 3.12.

Please consider this PR @nicholas-ramsey as this library is no longer compatible with python 3.12.

@bdsoha
Copy link
Contributor

bdsoha commented Feb 18, 2024

@alanyee This has been implemented, seems like this can be closed.

@alanyee
Copy link
Author

alanyee commented Feb 21, 2024

@bdsoha I will close this PR since it is no longer needed, but this PR was to make it Python 2 compatible. With the new change, Python 3 should be enforced by setup.py which I will make a PR for.

@alanyee alanyee closed this Feb 21, 2024
@alanyee alanyee deleted the patch-1 branch February 21, 2024 03:54
@alanyee
Copy link
Author

alanyee commented Feb 21, 2024

#46 is the small iteration of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants