Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#156 fix splitter handle #157

Merged

Conversation

davemasselink
Copy link
Collaborator

@davemasselink davemasselink commented Mar 27, 2019

Fixing splitter handle by way of modifying a forked version of the library and depending on that, instead. This should work the same across deployed envs.

Screen Shot 2019-03-26 at 5 23 45 PM

David Masselink and others added 30 commits December 22, 2018 16:13
…modeled on recent changes to results/results list
…class to a node ID under our control

* also leaving a TODO comment for @ssmails
@davemasselink davemasselink self-assigned this Mar 27, 2019
@davemasselink davemasselink added bug Something isn't working UI front-end related labels Mar 27, 2019
@davemasselink davemasselink changed the title #153 fix splitter handle #156 fix splitter handle Mar 27, 2019
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #157 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   62.08%   62.19%   +0.11%     
==========================================
  Files          38       38              
  Lines        1791     1791              
  Branches      139      139              
==========================================
+ Hits         1112     1114       +2     
+ Misses        545      544       -1     
+ Partials      134      133       -1
Impacted Files Coverage Δ
app/src/components/results/Results.js 58.97% <ø> (ø) ⬆️
app/src/components/graph/GraphContainer.js 64.1% <ø> (ø) ⬆️
app/src/components/home/Home.js 84.21% <ø> (ø) ⬆️
service/db/dgclient.go 65.31% <0%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b38a9...9717608. Read the comment docs.

…rade to v4.0.0 where a custom css file can be provided more simply
@davemasselink
Copy link
Collaborator Author

@fzxu, I ended up making the change to use v4.0.0 of react-splitter-layout rather than my fork of it directly in this PR. So, this PR now covers #158 which I'll close as a dupe

Copy link
Collaborator

@fzxu fzxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davemasselink davemasselink merged commit 752be08 into intuit:master Apr 2, 2019
@davemasselink davemasselink deleted the bugfix/#153-fix-splitter-handle branch April 2, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI front-end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants