Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/#140-collapsable-detail-drawer #147

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
a3181dd
extend-graph-navigation - initial extension of graph/graphcontainer c…
Dec 22, 2018
c7ff270
extend-graph-navigation - fix merge conflict, need to get upstream ma…
Dec 26, 2018
232cf16
extend-graph-navigation - fix merge conflicts WRT upstream master
Dec 26, 2018
c298c24
extend-graph-navigation - add new entity related actions
Jan 2, 2019
ecdf7db
extend-graph-navigation - addl changes related to entity related redu…
Jan 2, 2019
b21dfe1
extend-graph-navigation - graph and graph container related changes
Jan 2, 2019
cedc7f3
extend-graph-navigation - updating tests so as to wrap GraphContainer…
Jan 2, 2019
ce55021
Merge branch 'master' into feature/extend-graph-navigation
Jan 2, 2019
b09ace2
extend-graph-navigation - adding use of splitter to graph container, …
Jan 2, 2019
8fbaf88
extend-graph-navigation - clean-up home component, re-center headers
Jan 2, 2019
e563cb2
Merge branch 'master' into feature/extend-graph-navigation
Jan 4, 2019
8a5f5c6
extend-graph-navigation - incorporating review feedback and some gene…
Jan 7, 2019
bc8206a
Merge branch 'feature/extend-graph-navigation' of https://github.com/…
Jan 7, 2019
2cf0085
Merge branch 'master' into feature/extend-graph-navigation
Jan 7, 2019
efc670b
extend-graph-navigation - merge fixes, updated alpha channel in logo …
Jan 7, 2019
4fca129
extend-graph-navigation - get recursive navigation working with entit…
Jan 8, 2019
e460a0f
extend-graph-navigation - fixing broken test cases which somehow stil…
Jan 8, 2019
8cdd591
Merge remote-tracking branch 'upstream/master'
Jan 11, 2019
b4ce614
fix-notifier-tests by changing from looking for an autogenerated CSS …
Jan 11, 2019
98f3b41
Merge branch 'master' into bug/fix-notifier-tests
Jan 11, 2019
d475805
Merge remote-tracking branch 'upstream/master'
Jan 11, 2019
03be1a9
Merge branch 'bug/fix-notifier-tests'
Jan 11, 2019
14f73c0
Merge remote-tracking branch 'upstream/master'
Feb 1, 2019
45ddbb5
Merge remote-tracking branch 'upstream/master'
Feb 6, 2019
9ba0f04
Merge remote-tracking branch 'upstream/master'
Feb 11, 2019
1ed65fd
Merge remote-tracking branch 'upstream/master'
Feb 13, 2019
a495ef2
Merge remote-tracking branch 'upstream/master'
Feb 15, 2019
bfa6e6f
Merge remote-tracking branch 'upstream/master'
Feb 21, 2019
b819f70
Merge remote-tracking branch 'upstream/master'
Feb 28, 2019
7d63d04
Merge remote-tracking branch 'upstream/master'
Mar 1, 2019
edfe9b4
Merge remote-tracking branch 'upstream/master'
Mar 20, 2019
94f3a1f
#140 - make collapsable drawer default to closed, but with a larger, …
Mar 21, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/src/components/app/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import Home from "../home/Home";
import Results from "../results/Results";
import GraphContainer from "../graph/GraphContainer";
import Notifier from '../notifier/Notifier';
import ErrorPage from '../errorPage/ErrorPage';

export default class App extends Component {
render() {
Expand All @@ -17,6 +18,8 @@ export default class App extends Component {
<Route exact path="/" component={Home} />
<Route path="/results" component={Results} />
<Route path="/graph/:uidOrQsl" component={GraphContainer} />
{/* catch-all route in case of no earlier match */}
<Route component={ErrorPage} />
</Switch>
</div>
);
Expand Down
14 changes: 14 additions & 0 deletions app/src/components/errorPage/ErrorPage.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
.Error {
min-height: 5vh;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
font-size: calc(10px + 1vmin);
}

.Error-logo-full {
height: auto;
width: auto;
margin: 20px;
}
28 changes: 28 additions & 0 deletions app/src/components/errorPage/ErrorPage.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import React from 'react';
import { withRouter } from 'react-router-dom';
import { withStyles } from '@material-ui/core/styles';

import './ErrorPage.css';
import logo from './katlas-logo-blue-300px.png';

const styles = () => ({
title: {
textAlign: 'center'
}
});

class ErrorPage extends React.Component {
render() {
const { classes } = this.props;
return (
<div className='Error'>
<div className={classes.title}>
<h3>Something appears to have gone wrong. Please retry your operation.</h3>
</div>
<img src={logo} className='Error-logo-full' alt='logo' />
</div>
);
}
}

export default withStyles(styles)(withRouter(ErrorPage));
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion app/src/components/graph/GraphContainer.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ class GraphContainer extends Component {
</div>
) : null
}
<SplitterLayout percentage={true} secondaryInitialSize={30}>
<SplitterLayout percentage={true} secondaryInitialSize={0}>
<Graph dataSet={entity.results}/>
<EntityDetails selectedObj={entity.results}/>
</SplitterLayout>
Expand Down
6 changes: 5 additions & 1 deletion app/src/components/results/ResultList.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import Tooltip from '@material-ui/core/Tooltip';
import { ResultPaginationActionsWrapped } from './ResultPaginationActions';
import { getQueryLayout, rowCellsFromLayout } from './layoutComposer';
import { addResourceIdFilterQSL } from "../../utils/validate";
import history from '../../history';

// Customized table cell theme
export const CustomTableCell = withStyles(theme => ({
Expand Down Expand Up @@ -115,9 +116,12 @@ class ResultList extends Component {

tableRows = query.results.map((item, idx) => {
let cells = rowCellsFromLayout(item, layout);
//build url to use for QSL in graph action; include basename, if applicable
let rowUrl = (history.basename ? history.basename : '' ) + '/graph/' +
addResourceIdFilterQSL(query.current, item.resourceid);
cells.unshift(
<CustomTableCell key={item.uid}>
<a className={classes.link} href={'/graph/' + addResourceIdFilterQSL(query.current, item.resourceid)}>
<a className={classes.link} href={rowUrl}>
<Tooltip title="Response Object in Graph View" aria-label="Response in Graph">
<IconButton className={classes.button} variant='contained' color='primary' size='small'>
{'\uf0e8'}
Expand Down
6 changes: 6 additions & 0 deletions app/src/components/results/Results.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
.splitter-layout > .layout-splitter {
width: 12px;
background-image: url("./grabIcon.png");
background-position: center;
background-repeat: no-repeat;
}
4 changes: 3 additions & 1 deletion app/src/components/results/Results.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import EntityDetails from '../entityDetails/EntityDetails';
import * as queryActions from '../../actions/queryActions';
import { getQueryParam } from '../../utils/url';

import './Results.css';

const styles = theme => ({
progress: {
margin: theme.spacing.unit * 2
Expand Down Expand Up @@ -144,7 +146,7 @@ class Results extends Component {
) : (
<SplitterLayout
percentage={true}
secondaryInitialSize={30}
secondaryInitialSize={0}
customClassName={classes.resultContainer}
>
<ResultList
Expand Down
Binary file added app/src/components/results/grabIcon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.