Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #134 #135

Merged
merged 3 commits into from
Mar 21, 2019
Merged

fix issue #134 #135

merged 3 commits into from
Mar 21, 2019

Conversation

formuzi
Copy link
Collaborator

@formuzi formuzi commented Mar 7, 2019

  1. QSL to support dashed keyname
  2. fix full sync API timeout problem after add more k8s clusters
  3. support special chars when QSL query is part of http URL
    e.g. pod[@containers.$image="k8s.io/test"]{*}

1. QSL to support dashed keyname
2. fix full sync API timeout problem after add more k8s clusters
3. support special chars when QSL query is part of http URL, e.g. pod[@containers.$image="k8s.io/test"]{*}
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #135 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #135     +/-   ##
========================================
+ Coverage    62.1%   62.2%   +0.1%     
========================================
  Files          37      37             
  Lines        1760    1786     +26     
  Branches      128     138     +10     
========================================
+ Hits         1093    1111     +18     
- Misses        535     542      +7     
- Partials      132     133      +1
Impacted Files Coverage Δ
service/apis/entity_service.go 74.01% <100%> (+0.14%) ⬆️
service/apis/qsl_service.go 69.42% <100%> (ø) ⬆️
app/src/services/ApiService.js 78.78% <0%> (-4.55%) ⬇️
app/src/components/results/ResultList.js 36.58% <0%> (-1.88%) ⬇️
app/src/utils/validate.js 98.48% <0%> (-1.52%) ⬇️
service/db/dgclient.go 64.73% <0%> (-1.45%) ⬇️
app/src/components/results/layoutComposer.js 45.45% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2103f62...3b08a66. Read the comment docs.

@fzxu
Copy link
Collaborator

fzxu commented Mar 18, 2019

has the new return code tested with the current UI?

@formuzi formuzi merged commit c0529ed into intuit:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants