feat: added ability to specify the activity type if needed #123
Conversation
|
for issue: #120 |
|
@lwdupont The CLActivityTypeAirborne is only compatible with iOS 12 and above. Should we update the travis build environment to run on iOS 12? |
| Asynchronously requests the current location of the device using location services, optionally delaying the timeout countdown until the user has | ||
| responded to the dialog requesting permission for this app to access location services. | ||
|
|
||
| @param desiredAccuracy The accuracy level desired (refers to the accuracy and recency of the location). |
There was a problem hiding this comment.
Great job on the comments/headers!! 💯
| { | ||
| switch (desiredActivityType) { | ||
| case CLActivityTypeFitness: | ||
| if (self.locationManager.activityType != CLActivityTypeFitness) { |
There was a problem hiding this comment.
Is it good practice to check if it's currently what you are about to set it? (maybe so that it doesn't fire up location services on the switch?)
(vs was I was expecting was just setting the activityType)
There was a problem hiding this comment.
I don't think there is any real reason to check it before hand. At this point you have already requested a new location reading and there is no MAX activity type. I'll go ahead and remove this redundant check.
| @@ -70,8 +68,24 @@ | |||
| <action selector="desiredAccuracyControlChanged:" destination="vXZ-lx-hvc" eventType="valueChanged" id="HLd-94-Htx"/> | |||
| </connections> | |||
| </segmentedControl> | |||
| <segmentedControl opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="left" contentVerticalAlignment="top" apportionsSegmentWidthsByContent="YES" segmentControlStyle="plain" selectedSegmentIndex="0" translatesAutoresizingMaskIntoConstraints="NO" id="ujK-C3-t78"> | |||
There was a problem hiding this comment.
And thank you for updating the example app too!!!!! 👍 🥇
There was a problem hiding this comment.
These are great changes, thank you @dcortright ! Just had one question for my sake, see the comment.
|
@dcortright And yes, I'd say let's go and increase Travis to build on iOS 12. Thanks. |
|
@lwdupont Should I leave the pod file at iOS 10? Or bump that up to 12 as well? |
|
I say got to iOS 12 too. We can bump the version when we release to something higher than a .0.1 |
|
@lwdupont Done! Updated .travis.yml and pod file. |
|
If possible could I also get assigned to this as well as get the hacktoberfest label added? Thank you for all your help! |
|
Thanks, looks great to me! :) I assigned you, and added the label too. |
|
Thanks @lwdupont! That was my first contribution to open source and it was pretty fun! |
|
You did an awesome job @dcortright ! I'll look tomorrow to release this to Cocoapods too, so people can use it :) |
The iOS activity types, CLActivityType, help the iOS determine what type of activity is being tracked and when/if the tracking should be paused based on how long the device has been stationary.
This PR allows the user to set the activity type for their specific use case. CLLocationManager defaults to CLActivityTypeOther and will continue to do so if not set by the user.