Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Indexing Changes for Codeium #544

Conversation

RoshanNagaram-eng
Copy link
Contributor

  • Added Support to extract dir from workspace, before we were just analyzing the workspace and not the actual repos in the workspace for indexing

@intitni intitni changed the base branch from main to develop June 30, 2024 15:53
@intitni intitni changed the base branch from develop to feature/merging-codeium-indexing June 30, 2024 15:56
@intitni
Copy link
Owner

intitni commented Jun 30, 2024

Thank you!

@intitni intitni merged commit 8d16631 into intitni:feature/merging-codeium-indexing Jun 30, 2024
@intitni
Copy link
Owner

intitni commented Jun 30, 2024

Just some follow up:

It looks like the language server is now able to track multiple workspaces?

If this is the case, and you no longer need multiple language servers for each workspace, you can move the codeiumServer from CodeiumWorkspacePlugin into CodeiumExtension. Make sure to update the terminate method, too.

@RoshanNagaram-eng
Copy link
Contributor Author

RoshanNagaram-eng commented Jul 1, 2024

Just to clarify the language server can track multiple projects within still only a single workspace. Would the suggestion you stated above still apply?

@intitni
Copy link
Owner

intitni commented Jul 2, 2024

Then we should just keep it the way it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants