Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document cold.counter breaking changes for babbage #4116

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Document cold.counter breaking changes for babbage #4116

merged 2 commits into from
Jul 22, 2022

Conversation

CarlosLopezDeLara
Copy link
Contributor

  • New rules for cold.counter (increment by exactly 1)
  • How to find on-chian counter value
  • How to revert an invalid certificate
  • How to issue new opcert when no block has been forged in current KES interval

closes #3959

@CarlosLopezDeLara CarlosLopezDeLara mentioned this pull request Jun 30, 2022
Closed
1 task
Jimbo4350
Jimbo4350 reviewed Jul 4, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

doc/stake-pool-operations/KES_period.md Show resolved Hide resolved
doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
@olgahryniuk olgahryniuk mentioned this pull request Jul 5, 2022
Closed
@CarlosLopezDeLara CarlosLopezDeLara force-pushed the counter-op branch 2 times, most recently from bea1122 to 156fa01 Compare July 5, 2022 16:13
@CarlosLopezDeLara CarlosLopezDeLara mentioned this pull request Jul 6, 2022
Open
2 tasks
Jimbo4350
Jimbo4350 reviewed Jul 8, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good. A few more comments

doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
doc/stake-pool-operations/KES_period.md Outdated Show resolved Hide resolved
@CarlosLopezDeLara
KES, Opcert and counter
deee4bd 
minor amendments
@CarlosLopezDeLara
Copy link
Contributor Author

Closes #3959

@rdlrt
Copy link

rdlrt commented Jul 21, 2022

Closes 3959

Does not attempt to document answer to first question of linked issue (why?) - just states that this is changed?

@CarlosLopezDeLara
Copy link
Contributor Author

Closes 3959

Does not attempt to document answer to first question of linked issue (why?) - just states that this is changed?

We are writing a separate blog post to explain the reasons for the change.

@CarlosLopezDeLara
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 22, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 1e9fd19 into master Jul 22, 2022
@iohk-bors iohk-bors bot deleted the counter-op branch July 22, 2022 01:11
@rdlrt rdlrt mentioned this pull request Aug 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy left review comments

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document that the op cert counter should be exactly one more than the previously used op cert
4 participants
@CarlosLopezDeLara @rdlrt @newhoggy @Jimbo4350