Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - Update kes-period-info to check counter on Babbage #3963

Open
1 of 2 tasks
CarlosLopezDeLara opened this issue Jun 1, 2022 · 2 comments
Open
1 of 2 tasks

[FR] - Update kes-period-info to check counter on Babbage #3963

CarlosLopezDeLara opened this issue Jun 1, 2022 · 2 comments
Assignees
Labels
API&CLI-Backlog area: kes-info comp: cardano-cli enhancement New feature or request era: babbage in-scope This item is being worked and will be part of an upcoming release priority low Issues/RPs that are low priority issues/PRs in relation to a minimum Shelley testnet and Shelley mai type: internal feature Non user-facing functionality user type: internal Created by an IOG employee Vasil

Comments

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Jun 1, 2022

After the hardfork we will only be able to bump the op cert counter by exactly 1. We will need to:

From #3945

Reference: https://input-output-rnd.slack.com/archives/C02CHLB0BU4/p1654081538236349?thread_ts=1654078816.490359&cid=C02CHLB0BU4

@CarlosLopezDeLara CarlosLopezDeLara added the enhancement New feature or request label Jun 1, 2022
@dorin100 dorin100 added the Vasil label Jun 3, 2022
@CarlosLopezDeLara CarlosLopezDeLara added priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn priority high issues/PRs that MUST be addressed. The release can't happen without this; 1.35.1 Include in 1.35.1 and removed priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn labels Jun 27, 2022
@dcoutts
Copy link
Contributor

dcoutts commented Jul 1, 2022

I note that this command also appears to need to use the query for the protocol state, which is a somewhat unstable format. It'd be better if "production" commands (as opposed to debug state dump commands) used specific queries rather than poking about in the protocol state or ledger state. That way we can make them backwards compatible more easily.

@CarlosLopezDeLara CarlosLopezDeLara added priority low Issues/RPs that are low priority issues/PRs in relation to a minimum Shelley testnet and Shelley mai and removed priority high issues/PRs that MUST be addressed. The release can't happen without this; labels Jul 6, 2022
@CarlosLopezDeLara
Copy link
Contributor Author

CarlosLopezDeLara commented Jul 6, 2022

Lowering priority since kes-period-info "as is" already provides the required information. Adding --output-counter would be an enhancement.

@CarlosLopezDeLara CarlosLopezDeLara added 1.35.2 and removed 1.35.1 Include in 1.35.1 labels Jul 8, 2022
@CarlosLopezDeLara CarlosLopezDeLara added in-scope This item is being worked and will be part of an upcoming release and removed 1.35.2 labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API&CLI-Backlog area: kes-info comp: cardano-cli enhancement New feature or request era: babbage in-scope This item is being worked and will be part of an upcoming release priority low Issues/RPs that are low priority issues/PRs in relation to a minimum Shelley testnet and Shelley mai type: internal feature Non user-facing functionality user type: internal Created by an IOG employee Vasil
Projects
None yet
Development

No branches or pull requests

4 participants