Return version logging to prices DB table

[artur-intech]

PaperTrail's Version model itself has been removed in #475, so those
columns are now useless

[vohmar]

merge conflict with master

[vohmar]

how does the registry currently log who made a change in pricelists? is the data collected and saved in the columns creator_str and updator_str preserved somewhere?

[artur-intech]

Changes are not logged. I guess "Update price" button should be taken away http://prntscr.com/l1vmtr. Otherwise I don't see a point of having "Expire" button.

[vohmar]

there is a reason for expire - price promotions. The use-case example is

• you have a regular price beginning from 1.01.2018 without end date
• now you want to have special temporary price promotion - one might add new price list record with starting and end date or if the end date is not set leave end date blank and expire the record once the moment arrives. So the expire button is basically quick action for updating the current price list record's end date to the moment of the button press.
• update price offers more freedom - to change the start date, the price but basically it should be used only if there was some error, In regular operations when one wants to set a new price new record should be created and the last one expired.

It might be worth to discuss if there should be only one button like expire, but either way any changes made to any record incl price list entries should be logged and thus I do not see how could we drop papertrail columns for price list without replacing these with some alternative way of tracking changes.

[artur-intech]

Just to be sure you understand: currently, there is no audit log for prices at all. Presence of columns in question has no effect on that. They are useless.

Based on your last comment, we probably need to restore this feature. But in this case I wonder why have we removed it in the first place.

[teadur]

Just to be sure you understand: currently, there is no audit log for prices at all. Presence of columns in question has no effect on that. They are useless.

Based on your last comment, we probably need to restore this feature. But in this case I wonder why have we removed it in the first place.

Actually the columns in question are filled for data generated before deploying #475 and as of no new prices have been defined after that currently we haven't "lost" any data.

But thats good question why paper trail was removed from this table, sadly #475 doesn't have any reasoning, but sounds like data what should be audited for sure.

[vohmar]

the problem is not with the columns but with removed logging / version handling.

[artur-intech]

@vohmar If I remember correctly, you said it is not needed. Should I close this PR and make a new ticket to restore versioning for Price model?

[artur-intech]

@vohmar Reminder.

[vohmar]

Yes we need to track changes with prices as with anything else in the registry - need to restore change tracking. It does not have to be handled by papertrail.

[teadur]

possibly will be fixed by #1563