Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CodeClimate config #854

Merged
merged 8 commits into from
Jun 21, 2018
Merged

Improve CodeClimate config #854

merged 8 commits into from
Jun 21, 2018

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented May 31, 2018

Nothing to test.

  • Show all offences
  • Use shared rubocop.yml
  • Remove customizations
  • Remove unneeded gems

Copy link
Contributor

@maciej-szlosarczyk maciej-szlosarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Loads of work to do.

@artur-intech
Copy link
Contributor Author

artur-intech commented Jun 4, 2018

Definitely. Before there was .rubocop-to-do file, regenerated based on issues at the time of generation, but I found that this approach just doesn't work. You need to either find&replace file/folder names and/or regenerate it as long you fix something. It's more effort than benefit. Let's try to minimize the amount of issues with every next change.

I think it's better to be honest with ourselves and have all problems clearly defined.

@artur-intech
Copy link
Contributor Author

artur-intech commented Jun 4, 2018

What I would do, is remove this badge from project's front page. It's a bit awkwardly to "start a book with erratum".
http://prntscr.com/jqkgw5

@vohmar
Copy link
Contributor

vohmar commented Jun 6, 2018

code climate seems stuck with analysis

@maciej-szlosarczyk
Copy link
Contributor

I restarted the thing, the check is complete now.

@artur-intech
Copy link
Contributor Author

artur-intech commented Jun 6, 2018

@vohmar So how about removing that badge (see a comment above)?

@vohmar
Copy link
Contributor

vohmar commented Jun 14, 2018

@artur-beljajev as we discussed, lets leave the badge as is - removing it does not improve anything except hinding the current state of things from general public. It's an open source project - lets be open.

@artur-intech artur-intech force-pushed the improve-code-climate branch from 29d8372 to 3b996a5 Compare June 18, 2018 13:54
@vohmar vohmar merged commit 9a49e87 into master Jun 21, 2018
@vohmar vohmar deleted the improve-code-climate branch June 27, 2018 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants