Registry #419 #829
Registry #419 #829
Conversation
* Refactor BankLink into Payments::BankLink, add Payments::EveryPay * Write tests for existing invoice views * Write basic tests for Payments module
maciej-szlosarczyk
force-pushed
the
credit-and-debit-card-payments
branch
3 times, most recently
from
144cef3 to
d76e9c1
Compare
maciej-szlosarczyk
force-pushed
the
credit-and-debit-card-payments
branch
from
d76e9c1 to
33a6971
Compare
|
|
app/models/payments/base.rb
Outdated
| end | ||
|
|
||
| def complete_transaction | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Perhaps we could remove methods that are required to be implemented by subclass, and instead reply on NameError exception which will be thrown if a method is not found?
Also, it seems NotImplementedError usage scope is a bit different.
| %h4= "Credit card payment successful" | ||
| %hr | ||
| %dl.dl-horizontal | ||
| %dt= t(:invoice) |
There was a problem hiding this comment.
How about creating separate translation files, instead of replying on "globals" from en.yml? t '.invoice shortcut might be handy, for example
| @@ -0,0 +1,4 @@ | |||
| = form_tag "https://igw-demo.every-pay.com/transactions/", method: :post do | |||
There was a problem hiding this comment.
Should it really be here? This seems to be some demo instance, isn't it?
| @other_pay = Payments::EveryPay.new('every_pay', @invoice, {}) | ||
|
|
||
| # To avoid problems with time conversion. | ||
| travel_to Time.at(1522542600) |
There was a problem hiding this comment.
Looks cryptic. Any chance using travel_to Time.zone.parse('xxxx-xx-xx')?
Allow for nil values in `ENV['payment_intermediaries']` and `ENV['payments_banks']`
maciej-szlosarczyk
force-pushed
the
credit-and-debit-card-payments
branch
from
6154bc8 to
a1bbdc0
Compare
No description provided.