Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make admin contacts optional for private registrants #2730

Merged

Conversation

OlegPhenomenon
Copy link
Contributor

Close:
#2701
#2702

Binded to: internetee/registrar_center2#135

This change makes admin contacts optional for private registrants while keeping them mandatory for organizations. The changes include:

  • Updated Domain model validations to make admin and tech contacts optional (min=0) for private registrants
  • Added validation rules methods to handle different requirements based on registrant type
  • Modified EPP domain creation to support domains without admin contacts for private registrants
  • Updated attach_default_contacts to skip adding contacts for private registrants
  • Added comprehensive test coverage for:
    • Domain model validations with private/org registrants
    • EPP domain creation without admin contacts for private registrants
    • REPP API contact management for private registrants

This implements the requirement to make admin contacts optional for private registrations of .ee domains while maintaining the existing validation rules for organizations.

This change makes admin contacts optional for private registrants while keeping them mandatory for organizations. The changes include:

- Updated Domain model validations to make admin and tech contacts optional (min=0) for private registrants
- Added validation rules methods to handle different requirements based on registrant type
- Modified EPP domain creation to support domains without admin contacts for private registrants
- Updated attach_default_contacts to skip adding contacts for private registrants
- Added comprehensive test coverage for:
  - Domain model validations with private/org registrants
  - EPP domain creation without admin contacts for private registrants
  - REPP API contact management for private registrants

This implements the requirement to make admin contacts optional for private registrations of .ee domains while maintaining the existing validation rules for organizations.
@vohmar vohmar merged commit a9b341e into master Jan 28, 2025
7 checks passed
@vohmar
Copy link
Contributor

vohmar commented Jan 30, 2025

Current solution lets any domain to be registered without setting admin contacts if the 0 admin contact condition is enabled in admin.

.ee policy requires the admin contact if the registrant is an organisation. It is also needed if the private registrant is a minor (under 18 years old)

how can i enforce the correct admin contact policy?

@vohmar
Copy link
Contributor

vohmar commented Jan 30, 2025

i was able to set an org type of contact in the role of the admin contact. admin contact can only be private

@vohmar vohmar assigned OlegPhenomenon and unassigned vohmar Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants