Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix check force delete lift poll messages #2461

Merged
merged 2 commits into from
Oct 17, 2022
Merged

fix check force delete lift poll messages #2461

merged 2 commits into from
Oct 17, 2022

Conversation

thiagoyoussef
Copy link
Member

@thiagoyoussef thiagoyoussef commented Oct 15, 2022 •
edited
Loading

close #2460

@thiagoyoussef thiagoyoussef self-assigned this Oct 15, 2022
@viezly
Copy link

viezly bot commented Oct 15, 2022 •
edited
Loading

Changes preview:

Legend:

👀 Review pull request on Viezly

@thiagoyoussef
Copy link
Member Author

I removed the poll message. It does not make sense to send a poll message saying that the FD was set on the domain if we are going to lift it right after.
What we could do on the future is to create a new poll message saying that we lifted the domain.
Please test if now is lifting the correct domains.

@vohmar vohmar merged commit 4510616 into master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thiagoyoussef thiagoyoussef

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary poll messages on running CheckForceDeleteLift.perform_now
2 participants
@thiagoyoussef @vohmar