business registry contacts - endpoints for send status of contacts and receive confirmation #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: Legend: |
OlegPhenomenon
force-pushed
the
confirmation-dialog-box-for-update-companies-contacts
branch
4 times, most recently
from
dafc6b9 to
7d3390e
Compare
…d receive confirmation
OlegPhenomenon
force-pushed
the
confirmation-dialog-box-for-update-companies-contacts
branch
from
7d3390e to
db012dd
Compare
maricavor
reviewed
Mar 24, 2022
app/models/registrant_user.rb
Outdated
|
|
||
| counter = 0 | ||
| companies.each do |company| | ||
| contacts = Contact.where(ident: company.registration_number, ident_country_code: 'EE') |
There was a problem hiding this comment.
its better to use one Active Record query here, than iterations:
counter += Contact.where(ident: company.registration_number, ident_country_code: 'EE') .where('name != ?', company.company_name).size
OlegPhenomenon
force-pushed
the
confirmation-dialog-box-for-update-companies-contacts
branch
from
52fa295 to
71655c4
Compare
maricavor
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.