Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Whois record updating for domain release #1784

Merged
merged 6 commits into from
Jan 28, 2021

Conversation

yulgolem
Copy link
Contributor

@yulgolem yulgolem commented Jan 4, 2021

Closes #1139

@yulgolem yulgolem force-pushed the 1139-fix-whois-for-domain-release branch from 771bd94 to d20d9cf Compare January 4, 2021 13:42
@yulgolem yulgolem force-pushed the 1139-fix-whois-for-domain-release branch 2 times, most recently from 0be2084 to 8121c30 Compare January 5, 2021 10:04
@yulgolem yulgolem force-pushed the 1139-fix-whois-for-domain-release branch from 8121c30 to 0c5ef72 Compare January 5, 2021 10:10
@yulgolem yulgolem marked this pull request as ready for review January 5, 2021 10:16
@yulgolem yulgolem removed the request for review from karlerikounapuu January 5, 2021 10:22
@yulgolem yulgolem marked this pull request as draft January 5, 2021 10:22
@yulgolem yulgolem marked this pull request as ready for review January 5, 2021 11:55
@yulgolem yulgolem force-pushed the 1139-fix-whois-for-domain-release branch from f43d09d to 1d5c46e Compare January 6, 2021 16:38
@vohmar
Copy link
Contributor

vohmar commented Jan 14, 2021

so here are the results from testing:

  1. set valid_to date of domain martin-20201109001.ee to 2020-11-30 22:00:00
  2. run expire, redemption and release jobs
  3. output from release job:
2021-01-14 16:50:47 UTC - Starting to update WHOIS record #<Whois::Record id: 5789, name: "martin-20201109001.ee", json: {"disclaimer"=>{"en"=>"Search results may not be used for commercial, advertising, recompilation, repackaging, redistribution, reuse, obscuring or other similar activities.", "et"=>"Otsitulemusi ei tohi kasutada ärilistel, reklaami, ümber töötlemise, edasi levitamise, taaskasutuse, muutmise ega muul sarnasel eesmärgil.", "ru"=>"Результаты поиска не могут быть использованы в коммерческих целях, включая, но не ограничиваясь, рекламу, рекомпиляцию, изменение формата, перераспределение либо переиспользование."}, "name"=>"martin-20201109001.ee", "status"=>["expired", "serverHold"], "registered"=>"2020-11-09T14:29:38+02:00", "changed"=>"2021-01-14T18:48:58+02:00", "expire"=>"2020-11-30", "outzone"=>"2020-12-15", "delete"=>"2021-01-14", "registrant"=>"Martin Äri 1", "registrant_kind"=>"org", "registrant_reg_no"=>"87492997", "registrant_ident_country_code"=>"EE", "email"=>"[email protected]", "registrant_changed"=>"2020-06-11T21:27:40+03:00", "registrant_disclosed_attributes"=>[], "admin_contacts"=>[{"name"=>"Atanasoski Kerttily", "email"=>"[email protected]", "changed"=>"2020-11-09T14:29:37+02:00", "disclosed_attributes"=>[]}], "tech_contacts"=>[{"name"=>"Klepnev Ismit", "email"=>"[email protected]", "changed"=>"2020-11-09T14:29:38+02:00", "disclosed_attributes"=>[]}], "registrar"=>"Registrar Second AS", "registrar_website"=>"http://suvalinejamps", "registrar_phone"=>"", "registrar_changed"=>"2020-08-03T15:36:06+03:00", "nameservers"=>["ns2.martin-20201109001.ee", "ns1.martin-20201109001.ee"], "nameservers_changed"=>"2020-11-09T14:29:38+02:00", "dnssec_keys"=>[], "dnssec_changed"=>nil}, created_at: "2020-11-09 12:29:41", updated_at: "2021-01-14 16:48:59">

from auction #<Auction id: 7428, domain: "martin-20201109001.ee", status: "started", uuid: nil, created_at: "2021-01-14 16:50:47", registration_code: nil, registration_deadline: nil>
2021-01-14 16:50:47 UTC - Updated from auction WHOIS record #<Whois::Record id: 5789, name: "martin-20201109001.ee", json: {"name"=>"martin-20201109001.ee", "status"=>["AtAuction"], "disclaimer"=>{"en"=>"Search results may not be used for commercial, advertising, recompilation, repackaging, redistribution, reuse, obscuring or other similar activities.", "et"=>"Otsitulemusi ei tohi kasutada ärilistel, reklaami, ümber töötlemise, edasi levitamise, taaskasutuse, muutmise ega muul sarnasel eesmärgil.", "ru"=>"Результаты поиска не могут быть использованы в коммерческих целях, включая, но не ограничиваясь, рекламу, рекомпиляцию, изменение формата, перераспределение либо переиспользование."}}, created_at: "2020-11-09 12:29:41", updated_at: "2021-01-14 16:50:47">
2021-01-14 16:50:47 UTC - Sending registrar notification
martin-20201109001.ee is released
Released total: 1

Not entirely sure we need to log down everything, but that is a minor issue

  1. Checked auctions table - record existed
  2. Checked whois_records tables in registry and registry_whois databases - no record found
  3. Checked the domain with whois request - "Domain not found"
  4. Restwhois response: Domain not found: martin-20201109001.ee.

@vohmar vohmar assigned yulgolem and unassigned vohmar Jan 14, 2021
@yulgolem
Copy link
Contributor Author

yulgolem commented Jan 15, 2021

OK, looks like fixed - checked myself on staging, domain with name sometimes-lose-but-always-win.ee and ID 92251 was destroyed, but Whois::Record with id 11015 persists:

<Whois::Record id: 11015, name: "sometimes-lose-but-always-win.ee", json: {"name"=>"sometimes-lose-but-always-win.ee", "status"=>["AtAuction"], "disclaimer"=>{"en"=>"Search results may not be used for commercial, advertising, recompilation, repackaging, redistribution, reuse, obscuring or other similar activities.", "et"=>"Otsitulemusi ei tohi kasutada ärilistel, reklaami, ümber töötlemise, edasi levitamise, taaskasutuse, muutmise ega muul sarnasel eesmärgil.", "ru"=>"Результаты поиска не могут быть использованы в коммерческих целях, включая, но не ограничиваясь, рекламу, рекомпиляцию, изменение формата, перераспределение либо переиспользование."}}, created_at: "2021-01-05 14:33:11", updated_at: "2021-01-15 11:18:21">
irb(main):037:0>

What have been done to check if everything works correctly:

  1. selected last domain
  2. set valid_to for this domain 2.months.ago
  3. run DomainCron.start_expire_period
  4. run DomainCron.start_redemption_grace_period
  5. run Domain.release_domains

@yulgolem yulgolem assigned vohmar and unassigned yulgolem Jan 15, 2021
@vohmar vohmar merged commit 8826c80 into master Jan 28, 2021
@vohmar vohmar deleted the 1139-fix-whois-for-domain-release branch January 28, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domain:release fails to create whois records for every domain released to auction
3 participants