Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return JSON response from 404 for Auction API #1608

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Return JSON response from 404 for Auction API #1608

merged 1 commit into from
Jun 11, 2020

Conversation

maciej-szlosarczyk
Copy link
Contributor

@maciej-szlosarczyk maciej-szlosarczyk commented Jun 11, 2020 •
edited
Loading

Fixes #1605

@maciej-szlosarczyk
Copy link
Contributor Author

maciej-szlosarczyk commented Jun 11, 2020 •
edited
Loading

Martin or Georg can verify, auction API should now return 404 with proper JSON:

% curl "https://registry.test/api/v1/auctions/not-really"
{"error":"Not Found","uuid":"not-really","message":"Record not found"}

NB! You need to be inside the auction API allowed IP list to execute this.

@vohmar vohmar merged commit 9524910 into master Jun 11, 2020
@vohmar vohmar deleted the return-json-errors-from-auction-api branch June 15, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlerikounapuu karlerikounapuu karlerikounapuu approved these changes

@yulgolem yulgolem yulgolem approved these changes

Assignees

@vohmar vohmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make auction API return JSON on error
4 participants
@maciej-szlosarczyk @yulgolem @karlerikounapuu @vohmar