Ensure all tests run on CI #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulgolem
approved these changes
May 22, 2020
karlerikounapuu
approved these changes
May 22, 2020
|
There is an issue with some intermittent test failures, but should be good to go for now. If the failures persist, we'd need to investigate more. |
|
has a merge conflict now that disputes branch is merged |
Probably with the upgrade of Rails from 4.2 to 5 the ids are no longer generated automatically in the views, but the functionality still worked as designed previously.
I also used the file we use for testing payments on staging, there was some issue with the other file and I am not sure what it was.
There seems to be an issue with the default configuration, files are missing and we depend on them for the tests to run.
yulgolem
force-pushed
the
ensure-all-tests-run-on-ci
branch
from
8afae0f to
106c506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tests that were missing environment config and such. I've re-used the test CA that I put into
epp_proxyat some specific point.@karlerikounapuu please ping me when you untangle the issue with contact viewing.