Store revoked state in Certificate model #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlerikounapuu
force-pushed
the
952-revoking-cert-does-not-stop-user-from-logging-in
branch
3 times, most recently
from
c0706cf to
3649dcb
Compare
karlerikounapuu
force-pushed
the
952-revoking-cert-does-not-stop-user-from-logging-in
branch
from
3649dcb to
2dbcbf1
Compare
yulgolem
approved these changes
May 8, 2020
karlerikounapuu
force-pushed
the
952-revoking-cert-does-not-stop-user-from-logging-in
branch
from
9859800 to
96b3986
Compare
karlerikounapuu
force-pushed
the
952-revoking-cert-does-not-stop-user-from-logging-in
branch
from
96b3986 to
c2f8589
Compare
karlerikounapuu
force-pushed
the
952-revoking-cert-does-not-stop-user-from-logging-in
branch
from
87c4bde to
04b10ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #952
When admin revokes certificate, revoked: true is applied to Certificate model. This is additionally used to check PKI validity (if apache doesn't kick the registrar beforehand).