log error when cert_path is missing #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Un configured cert_path in epp deployment will lead to registrar portal failing to connect to epp/repp with hard to debug error "no implicit conversion of nil into String" what refers to https://github.com/internetee/registry/compare/log-error-when-cert-path-is-missing?expand=1#diff-4e75b419751f5949efd2f5b537a19d4bR19
There are so many bad practices around the whole cert handling here i'm not even trying to fix them in this pr, rather provide meaningful error message to sysadmins to aid in debugging, this is only temporary/half solution and all exceptions here should be handled gracefully in future.
Ignore the commit name will be squash-merged