Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve domain and contact list download #1360

Merged
merged 7 commits into from
Oct 16, 2019
Merged

Improve domain and contact list download #1360

merged 7 commits into from
Oct 16, 2019

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented Oct 12, 2019 •
edited
Loading

Affects:

  • Domain list CSV download and search in registrar area
  • Contact list PDF/CSV download and search in registrar area
  • Domain list PDF/CSV download and search in registrant area

Slightly changes UI.

Needed for #377.

@artur-intech artur-intech force-pushed the improve-domain-and-contact-list-download branch 4 times, most recently from dfad6c9 to d8b335c Compare October 12, 2019 15:02
@artur-intech artur-intech marked this pull request as ready for review October 14, 2019 09:05
@vohmar
Copy link
Contributor

vohmar commented Oct 15, 2019

  • A bit less vague comments are appreciated: ie "download dropdown replaced with buttons" instead of "slightly changed UI"
  • Charactercode error - Estonian special characters are not supported in downloaded PDF files (csv is OK)
    image

@vohmar vohmar assigned artur-intech and unassigned vohmar Oct 15, 2019
@artur-intech
Copy link
Contributor Author

artur-intech commented Oct 15, 2019 •
edited
Loading

A bit less vague comments are appreciated: ie "download dropdown replaced with buttons" instead of "slightly changed UI"

My bad, was too lazy :(

Charactercode error - Estonian special characters are not supported in downloaded PDF files (csv is OK)

Nice catch, fixed.

@artur-intech artur-intech assigned vohmar and unassigned artur-intech Oct 15, 2019
@artur-intech artur-intech force-pushed the improve-domain-and-contact-list-download branch from 8e71087 to 90a90f3 Compare October 16, 2019 07:36
@artur-intech artur-intech mentioned this pull request Oct 16, 2019
Merged
@vohmar vohmar merged commit 526369f into master Oct 16, 2019
@vohmar vohmar deleted the improve-domain-and-contact-list-download branch January 2, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vohmar vohmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artur-intech @vohmar