Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registrar IBAN #1203

Merged
merged 6 commits into from
Jun 12, 2019
Merged

Add registrar IBAN #1203

merged 6 commits into from
Jun 12, 2019

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented May 16, 2019 •
edited
Loading

Requires #1202, #1204.
Needed for #329.

@artur-intech artur-intech mentioned this pull request May 16, 2019
Merged
@artur-intech artur-intech marked this pull request as ready for review May 30, 2019 13:04
@artur-intech artur-intech mentioned this pull request Jun 6, 2019
Merged
@vohmar vohmar assigned artur-intech and unassigned vohmar Jun 7, 2019
@artur-intech artur-intech assigned vohmar and unassigned artur-intech Jun 10, 2019
@vohmar
Copy link
Contributor

vohmar commented Jun 11, 2019

  • please replace the comment in profile view "Required for e-invoice" with "Required for sending e-invoices to the bank" - it is not needed if registrar wants e-invoice just to their ERP or email system.
  • Saving IBAN number in registrar portal returns error:
    image
    @staging and probably caused by some invalid data in registrar profile

@vohmar vohmar assigned artur-intech and unassigned vohmar Jun 11, 2019
@artur-intech artur-intech assigned vohmar and unassigned artur-intech Jun 12, 2019
@artur-intech
Copy link
Contributor Author

No. 1 is fixed.
No. 2 should be fixed manually, since reference_no is auto-generated required value.

@vohmar vohmar merged commit 09a6a3f into master Jun 12, 2019
@vohmar vohmar deleted the add-registrar-iban branch June 17, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vohmar vohmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artur-intech @vohmar