Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make registrar address required #1195

Merged
merged 2 commits into from
May 10, 2019
Merged

Make registrar address required #1195

merged 2 commits into from
May 10, 2019

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented May 10, 2019 •
edited
Loading

Includes refactoring of registrar admin views:

  • Reorganize views
  • Improve database structure
  • Use default translations
  • Combine tests

@artur-intech artur-intech assigned vohmar and unassigned vohmar May 10, 2019
@artur-intech artur-intech force-pushed the make-registrar-address-required branch from 07f5a14 to 90f0bc2 Compare May 10, 2019 10:52
Artur Beljajev added 2 commits May 10, 2019 16:40
Refactor registrars
efb6339 
- Reorganize views
- Improve database structure
- Use default translations
- Combine tests
Make registrar address required
0457529 
Closes #1190
@artur-intech artur-intech force-pushed the make-registrar-address-required branch from 90f0bc2 to 0457529 Compare May 10, 2019 13:41
@vohmar
Copy link
Contributor

vohmar commented May 10, 2019 •
edited
Loading

  • email value is on url line in pdf if website value is missing

@vohmar vohmar assigned artur-intech and unassigned vohmar May 10, 2019
@artur-intech
Copy link
Contributor Author

artur-intech commented May 10, 2019 •
edited
Loading

Cannot reproduce: http://prntscr.com/nmuwdo.

There is no registrar PDF view in admin area. Do you mean invoice PDF? If so, it is untouched, so the issue must be present in master as well...

@artur-intech artur-intech assigned vohmar and unassigned artur-intech May 10, 2019
@vohmar vohmar assigned artur-intech and unassigned vohmar May 10, 2019
@artur-intech artur-intech assigned vohmar and unassigned artur-intech May 10, 2019
@vohmar
Copy link
Contributor

vohmar commented May 10, 2019

the issue i not there in master as website is not present in invoice pdf in master

@vohmar vohmar assigned artur-intech and unassigned vohmar May 10, 2019
@artur-intech
Copy link
Contributor Author

See #1195 (comment). Anyway, I can't help if you don't post any screenshot.

@vohmar
Copy link
Contributor

vohmar commented May 10, 2019

image

@vohmar vohmar assigned vohmar and artur-intech and unassigned artur-intech and vohmar May 10, 2019
@artur-intech
Copy link
Contributor Author

Are you sure you can't reproduce it using master branch?

@vohmar
Copy link
Contributor

vohmar commented May 10, 2019

problem resolved it self

@vohmar vohmar merged commit 0d1ee54 into master May 10, 2019
@vohmar vohmar deleted the make-registrar-address-required branch May 13, 2019 10:21
@vohmar vohmar mentioned this pull request May 17, 2019
Closed
@artur-intech
Copy link
Contributor Author

artur-intech commented May 21, 2019 •
edited
Loading

2019-05-06 @ratM1n:

select count(*) from registrars where street is null
select count(*) from registrars where zip is null
select count(*) from registrars where city is null
select count(*) from registrars where state is null

All result in zero rows in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@artur-intech artur-intech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artur-intech @vohmar