Encode domain parts of all addresses in mailers as punycode #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artur-intech
force-pushed
the
enable-full-punycode-support-for-emails
branch
from
4e26d96 to
f303809
Compare
artur-intech
changed the title
artur-intech
force-pushed
the
enable-full-punycode-support-for-emails
branch
from
f303809 to
bee3288
Compare
|
merge conflict |
artur-intech
force-pushed
the
enable-full-punycode-support-for-emails
branch
from
bee3288 to
86b7b1d
Compare
|
the punycode domainnames need to be converted back to UTF whenever the domainname is displayed to the user. Ie registrant email change notification email contains the email address in the email body, registrant portal contact view, admin portal, registrant portal etc |
|
apparently the problem brought out is not related to this PR and is already present in master. I will create separate ticket for this issue about IDN domain name support in user interfaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvoiceMailer(introduced in https://github.com/internetee/registry/pull/1159/files).from,ccandbccfields.