Remove hardcoded default email sender #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artur-intech
changed the title
artur-intech
force-pushed
the
remove-hardcoded-default-email-sender
branch
from
f159401 to
4fe4984
Compare
artur-intech
changed the title
artur-intech
force-pushed
the
remove-hardcoded-default-email-sender
branch
4 times, most recently
from
bf1ed12 to
6b669bc
Compare
And make it configurable via `action_mailer_default_from` config. Closes #243
artur-intech
force-pushed
the
remove-hardcoded-default-email-sender
branch
from
6b669bc to
a113d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoded default email sender and make it configurable via
action_mailer_default_fromconfig.@ratM1n Should be set to
[email protected]in prod.Closes #243