Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create whois records on domain release #1143

Merged
merged 4 commits into from
Apr 8, 2019

Conversation

maciej-szlosarczyk
Copy link
Contributor

@maciej-szlosarczyk maciej-szlosarczyk commented Apr 3, 2019

Fixes an issue from staging.

@vohmar
Copy link
Contributor

vohmar commented Apr 3, 2019

on staging: three domains were released martin53.ee, martin54.ee and martin55.ee. After running domain:release martin53.ee returned not found in whois, the other two had at auction records in whois. All three had correct whois records before running domain:release. So the other two got new records created but 53 did not. Did number of redeploys and the result was consistent 53 never got new atauction record to whois, the other two always did.

@vohmar vohmar assigned maciej-szlosarczyk and unassigned vohmar Apr 3, 2019
@vohmar
Copy link
Contributor

vohmar commented Apr 4, 2019

the whois record for martin53.ee was created after ResultStatusUpdateJob after successful bid and end of the auction. So there is still something off with the domain:release task not creating the missing whois record.

@maciej-szlosarczyk
Copy link
Contributor Author

I have some idea what might go wrong there. Please, when you have time, try to test again. There should be an error raised when a whois record is not created.

@maciej-szlosarczyk
Copy link
Contributor Author

As it stands, this improves some previously butchered test names from #1140 and makes sure that the domain:release rake task does not fail if whois record does not exist (we saw that on staging).
Unfortunately the original issue remains unresolved.

@vohmar vohmar merged commit 19fbfbd into master Apr 8, 2019
@vohmar vohmar deleted the create-whois-records-on-domain-release branch April 30, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants