Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require reserved domain password #1063

Merged
merged 6 commits into from
Jan 4, 2019
Merged

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented Jan 2, 2019

  • Make reserved_domains.password DB column NOT NULL
  • Add tests
  • Add hint in UI
  • Remove dead code

Needed for #1062.


Verify reserved and blocked domains logic.

@artur-intech
Copy link
Contributor Author

Prod:

`registry=# select * from reserved_domains where password is null;
 id | created_at | updated_at | creator_str | updator_str | legacy_id | name | password 
----+------------+------------+-------------+-------------+-----------+------+----------
(0 rows)

registry=# select * from reserved_domains where password = '';
 id | created_at | updated_at | creator_str | updator_str | legacy_id | name | password 
----+------------+------------+-------------+-------------+-----------+------+----------
(0 rows)

@vohmar vohmar merged commit 012d53c into master Jan 4, 2019
@vohmar vohmar deleted the require-reserved-domain-password branch February 11, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants