Registry 992 #1042
Merged
Registry 992 #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artur-intech
force-pushed
the
registry-992
branch
2 times, most recently
from
8ab14e5 to
b00ca51
Compare
artur-intech
force-pushed
the
registry-992
branch
2 times, most recently
from
2f86a67 to
7a800d3
Compare
|
New issue with passing empty array has been discovered rails/rails#13420, so I am on the way fixing it by switching tests to use JSON in Also, it seems new field ( |
artur-intech
force-pushed
the
registry-992
branch
3 times, most recently
from
df6d3f9 to
928934a
Compare
artur-intech
force-pushed
the
registry-992
branch
from
928934a to
d695d95
Compare
|
@vohmar It's also worth verifying, that existing contacts with zero disclosed attributes (by default) behave as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1039
Do not deploy until #1038 is solved.
Closes #992.
This PR contains only API part. WHOIS and REST-WHOIS "front-end" parts will be implemented in respective projects.
It's needed to verify that API populates
registrant_disclosed_attributesanddisclosed_attributesJSON keys to WHOIS database.