Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in setting name #371

Closed
artur-intech opened this issue Feb 13, 2017 · 3 comments · Fixed by #1681
Closed

Fix typo in setting name #371

artur-intech opened this issue Feb 13, 2017 · 3 comments · Fixed by #1681
Assignees
@artur-intech
Labels
bug

Comments

@artur-intech
Copy link
Contributor

artur-intech commented Feb 13, 2017 •
edited
Loading

Setting.request_confrimation_on_registrant_change_enabled (notice "confrimation").
@artur-intech artur-intech self-assigned this Feb 13, 2017
@artur-intech artur-intech changed the title Fix setting's typo Fix setting name Feb 13, 2017
@artur-intech
Copy link
Contributor Author

artur-intech commented Feb 13, 2017 •
edited
Loading

@vohmar Is there any default value for this setting according to some EPP spec? Does the majority of registries require that confirmation?

@vohmar
Copy link
Contributor

vohmar commented Feb 14, 2017

this is custom setting specific to us. The idea is to protect registrant from admin contact. There are two tipes of requests for this model - registrant change and domain delete. In registry system the default state is disabled, it is configurable using admin interface and for .ee it is enabled for both registrant change and delete. How to use verified parameter/element related to these settings is described in epp doc in github

@artur-intech artur-intech changed the title Fix setting name Fix "request_confrimation_on_registrant_change_enabled" setting Feb 27, 2017
@artur-intech
Copy link
Contributor Author

the default state is disabled

Actually it is enabled:

registry/config/app.yml

Line 20 in e051784

request_confrimation_on_registrant_change_enabled: true

@artur-intech artur-intech changed the title Fix "request_confrimation_on_registrant_change_enabled" setting Fix typo in setting name Oct 19, 2019
artur-intech pushed a commit that referenced this issue Oct 19, 2019
Fix typo
2fac5d3 
Rename `request_confrimation_on_registrant_change_enabled` setting to
`verify_registrant_change`

Fixes #371
@artur-intech artur-intech mentioned this issue Oct 19, 2019
Closed
artur-intech pushed a commit that referenced this issue Oct 19, 2019
Fix typo
390c4ca 
Rename `request_confrimation_on_registrant_change_enabled` setting to
`verify_registrant_change`

Fixes #371
@yulgolem yulgolem mentioned this issue Sep 11, 2020
Merged
@vohmar vohmar added the bug label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artur-intech artur-intech

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in setting key internetee/registry
Fix typo internetee/registry
2 participants
@vohmar @artur-intech