Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EPP request-response examples #326

Closed
vohmar opened this issue Jan 2, 2017 · 4 comments
Closed

Update EPP request-response examples #326

vohmar opened this issue Jan 2, 2017 · 4 comments
Assignees

Comments

@vohmar
Copy link
Contributor

vohmar commented Jan 2, 2017

EPP request-response examples are outdated
registry/doc/epp-examples.md

for example:
https://github.com/internetee/registry/blob/master/doc/epp-examples.md#epp-contact-with-valid-user-create-command-successfully-creates-a-contact
this request should return code 1100 not 1000 in the light of current .ee domain regulations.

there should also be an example of request without <contact:addr> element that returns code 1000. As this doc is generated from model tests we should add also note about settings in case non-default values are used - address processing disabled for example.

@artur-intech artur-intech self-assigned this Feb 19, 2017
@artur-intech
Copy link
Contributor

artur-intech commented Feb 20, 2017

Might be connected to #351, #247

@artur-intech
Copy link
Contributor

artur-intech commented Feb 20, 2017

Those examples were previously generated using test:epp_doc rake task from the specs located at spec/epp. Those were not model specs (which are in spec/models folder).

All this stuff has been removed by #206. They were extremely hard to read and maintain them. Also, Apache web-server was required to run them, which is extremely slow and hard to support, if possible at all (say, running them on Jenkins).

To have updated examples, we need to implement new generator (long-term solution). As a quick fix, we could just manually update it.

@vohmar
Copy link
Contributor Author

vohmar commented Feb 27, 2017

Please update the examples. Will create separate ticket for fully automated solutions.

@artur-intech artur-intech changed the title Regenerate EPP request-response examples Update EPP request-response examples Mar 1, 2017
artur-intech pushed a commit that referenced this issue Mar 1, 2017
artur-intech pushed a commit that referenced this issue Mar 1, 2017
@artur-intech artur-intech assigned vohmar and unassigned artur-intech Mar 1, 2017
@vohmar
Copy link
Contributor Author

vohmar commented Mar 3, 2017

in production, branch deleted

@vohmar vohmar closed this as completed Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants