Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registrar website in invoice PDF is visible only if phone is present #1188

Closed
artur-intech opened this issue May 8, 2019 · 2 comments · Fixed by #1346
Closed

Registrar website in invoice PDF is visible only if phone is present #1188

artur-intech opened this issue May 8, 2019 · 2 comments · Fixed by #1346
Labels
bug

Comments

@artur-intech
Copy link
Contributor

artur-intech commented May 8, 2019 •
edited
Loading

https://github.com/internetee/registry/blob/master/app/views/invoice/pdf.haml#L210
@artur-intech
Copy link
Contributor Author

artur-intech commented May 8, 2019 •
edited
Loading

@vohmar I wonder if it is needed there at all.

@vohmar
Copy link
Contributor

vohmar commented May 8, 2019

this is obviously a bug - website should be visible if website address is present
and yes I think website is more useful detail than postal/billing address

artur-intech pushed a commit that referenced this issue May 9, 2019
Refactor billing
972ed6d 
Closes #1190, #1189, #1188
artur-intech pushed a commit that referenced this issue May 9, 2019
Refactor billing
1027c8f 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure

Closes #1190, #1189, #1188
artur-intech pushed a commit that referenced this issue May 10, 2019
Refactor invoices
7c4d2a5 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue May 10, 2019
Refactor invoices
68dd660 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue May 10, 2019
Refactor invoices
dca5502 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Remove `invoices.seller_id` database column as unused
- Improve database structure

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue May 15, 2019
Refactor invoices
445ed33 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Remove `invoices.seller_id` database column as unused
- Improve database structure

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue Jun 19, 2019
Refactor invoices
f17332b 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Remove `invoices.seller_id` database column as unused
- Improve database structure

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue Jun 19, 2019
Refactor invoices
18ceaa0 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue Jun 19, 2019
Refactor invoices
b77f8a3 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure
- Remove unnecessary validations

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue Jun 20, 2019
Refactor invoices
d5603b5 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure
- Remove unnecessary validations

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue Jun 20, 2019
Refactor invoices
6e47444 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure
- Improve UI
- Remove unnecessary validations

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue Jun 20, 2019
Refactor invoices
ee3e0b4 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure
- Improve UI
- Remove unnecessary validations

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue Jun 21, 2019
Refactor invoices
fa7e861 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure
- Improve UI
- Remove unnecessary validations

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue Jun 27, 2019
Refactor invoices
5f99bd8 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure
- Improve UI
- Remove unnecessary validations

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue Jul 11, 2019
Refactor invoices
7a78624 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure
- Improve UI
- Remove unnecessary validations

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue Jul 11, 2019
Refactor invoices
58baa18 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure
- Improve UI
- Remove unnecessary validations

Closes #1189, #1188
artur-intech pushed a commit that referenced this issue Jul 11, 2019
Refactor invoices
af1df09 
- Combine invoice seller and buyer address parts
- Convert HAML to ERB
- Extract translations
- Extract partials
- Improve database structure
- Improve UI
- Remove unnecessary validations

Closes #1189, #1188
teadur added a commit that referenced this issue Oct 8, 2019
@teadur
Fixes #1188
5955e16
@teadur teadur mentioned this issue Oct 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invoice pdf url display internetee/registry
2 participants
@vohmar @artur-intech