feat(2915): admin front-end for tenant support #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
4 tasks
4 tasks
# Conflicts: # localenv/mock-account-servicing-entity/generated/graphql.ts # packages/backend/src/graphql/generated/graphql.schema.json # packages/backend/src/graphql/generated/graphql.ts # packages/backend/src/graphql/resolvers/tenant.ts # packages/backend/src/graphql/schema.graphql # packages/frontend/app/generated/graphql.ts # packages/mock-account-service-lib/src/generated/graphql.ts # test/integration/lib/generated/graphql.ts
BlairCurrey
reviewed
Feb 6, 2025
BlairCurrey
reviewed
Feb 6, 2025
BlairCurrey
approved these changes
Feb 10, 2025
github-actions
bot
removed
type: tests
mkurapov
reviewed
Feb 12, 2025
mkurapov
reviewed
Feb 12, 2025
Comment on lines
248
to
257
| if ( | ||
| result.data.email && | ||
| result.data.email.trim().length > 0 && | ||
| !new RegExp(/^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$/).test( | ||
| result.data.email | ||
| ) | ||
| ) { | ||
| errors.fieldErrors.email = ['Email is invalid.'] | ||
| return json({ errors }, { status: 400 }) | ||
| } |
There was a problem hiding this comment.
Does const result = updateTenantSchema.safeParse(formEntries) take care of checking the email validation already?
There was a problem hiding this comment.
No, there is an issue with the optional vs regEx, that always forces the regex even when the field is marked as optional.
As a workaround, I am validating it as part of the action.
There was a problem hiding this comment.
Ah, I think we were just missing this
There was a problem hiding this comment.
As indicated by @mkurapov
colinhacks/zod#310
We have a workaround:
[`](email: z.string().email().or(z.literal('')),)
mkurapov
reviewed
Feb 12, 2025
mkurapov
approved these changes
Feb 12, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Fixes: #2915
Checklist
fixes #numberuser-docslabel (if necessary)