-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce line marker for wasm_bindgen attributes in WebAssembly projects #5933
Conversation
4b8f0c0
to
9e3fdca
Compare
js/src/main/kotlin/org/rust/js/RsWasmBindgenLineMarkerProvider.kt
Outdated
Show resolved
Hide resolved
9e3fdca
to
ae6fa18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: use more lightweight gutter icon
The current one looks too heavy (in my opinion, of course)
For example, C++ similar icon
Also, it would be great to come up with an extendable template for such icons because we can provide a similar feature for extern functions
Of course, don't insist to do it in this PR
There is an option to show JS file icon like PyCharm does for Flask templates. But I'm not sure if it is convenient to use a file icon here. We can use something similar to the C++ icon, then I think we should make it distinctive (but not standing out) from others as wasm_bindgen is a third-party thing to the language itself and its IDE features. A similar feature for extern functions would be cool. I'm not aware of the details but will try to find a way to keep these features in one area for the future. |
@Undin I think JS/TS icons is a clear and simple solution 👍 |
ae6fa18
to
5e46f63
Compare
5e46f63
to
fc0c5e1
Compare
js/src/main/kotlin/org/rust/js/RsWasmBindgenLineMarkerProvider.kt
Outdated
Show resolved
Hide resolved
js/src/main/kotlin/org/rust/js/RsWasmBindgenLineMarkerProvider.kt
Outdated
Show resolved
Hide resolved
js/src/main/kotlin/org/rust/js/RsWasmBindgenLineMarkerProvider.kt
Outdated
Show resolved
Hide resolved
js/src/main/kotlin/org/rust/js/RsWasmBindgenLineMarkerProvider.kt
Outdated
Show resolved
Hide resolved
js/src/main/kotlin/org/rust/js/RsWasmBindgenLineMarkerProvider.kt
Outdated
Show resolved
Hide resolved
js/src/main/kotlin/org/rust/js/RsWasmBindgenLineMarkerProvider.kt
Outdated
Show resolved
Hide resolved
js/src/main/kotlin/org/rust/js/RsWasmBindgenLineMarkerProvider.kt
Outdated
Show resolved
Hide resolved
fc0c5e1
to
07ca8a7
Compare
js/src/main/kotlin/org/rust/js/RsWasmBindgenLineMarkerProvider.kt
Outdated
Show resolved
Hide resolved
07ca8a7
to
b371f01
Compare
js/src/main/kotlin/org/rust/js/RsWasmBindgenLineMarkerProvider.kt
Outdated
Show resolved
Hide resolved
b371f01
to
41b85fc
Compare
js/src/main/kotlin/org/rust/js/RsWasmBindgenLineMarkerProvider.kt
Outdated
Show resolved
Hide resolved
41b85fc
to
2d69ab4
Compare
2d69ab4
to
8130bca
Compare
bors r+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about tests?
Build succeeded: |
@Undin We are going to add them later, in a separate PR |
Expected workflow: navigating from Rust statement to JS one. Then having the ability to navigate to JS parts related to it.
Current implementation
How it works
Related to #3066