MACRO&RES: initial version of include macro support #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undin
force-pushed
the
include-macro-first-attempt
branch
from
1c7e5e0 to
592c479
Compare
Undin
changed the title
Undin
force-pushed
the
include-macro-first-attempt
branch
from
592c479 to
3a2fa58
Compare
It leads to IndexNotReadyException because `getContext` can touch other files and call `resolve()`
Undin
force-pushed
the
include-macro-first-attempt
branch
from
3a2fa58 to
4a45020
Compare
|
👍 👍 👍 |
bors bot
added a commit
that referenced
this pull request
Jun 10, 2019
3935: MACRO&RES: initial version of include macro support r=vlad20012 a=Undin Add initial support of `include!` macro. It brings all common code insight features (like name resolution, code completion, etc.) in both including and included files. Also, it should fix false positive editor notification for included files.  Restrictions: * only string literals are supported as arguments * `include` macro call should be located only in a module. At this moment, if `include` macro is called in a function, it won't be indexed and as a result, won't be found via the corresponding index. So the current implementation works only with instances of `RsMod` Fixes #3563 Fixes problems described in #771 and #1078 in certain cases The initial step of #1908 3993: COMP & RES: Resolve const generics r=vlad20012 a=mchernyavsky Relates to #3985. Depends on #3990. Co-authored-by: Arseniy Pendryak <[email protected]> Co-authored-by: mchernyavsky <[email protected]>
Timed out (retrying...) |
bors bot
added a commit
that referenced
this pull request
Jun 10, 2019
3935: MACRO&RES: initial version of include macro support r=vlad20012 a=Undin Add initial support of `include!` macro. It brings all common code insight features (like name resolution, code completion, etc.) in both including and included files. Also, it should fix false positive editor notification for included files.  Restrictions: * only string literals are supported as arguments * `include` macro call should be located only in a module. At this moment, if `include` macro is called in a function, it won't be indexed and as a result, won't be found via the corresponding index. So the current implementation works only with instances of `RsMod` Fixes #3563 Fixes problems described in #771 and #1078 in certain cases The initial step of #1908 Co-authored-by: Arseniy Pendryak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial support of
include!macro. It brings all common code insight features (like name resolution, code completion, etc.) in both including and included files. Also, it should fix false positive editor notification for included files.Restrictions:
includemacro call should be located only in a module. At this moment, ifincludemacro is called in a function, it won't be indexed and as a result, won't be found via the corresponding index. So the current implementation works only with instances ofRsModFixes #3563
Fixes problems described in #771 and #1078 in certain cases
The initial step of #1908