-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
Signed-off-by: Amarnath Valluri <[email protected]>
excellent idea to separate device interface, allows cleaner implementation of #26 |
Current code is using two variants(lvm,ndctl) for managing(create,delete) underlined pmem devices. The better solution would be to define a generic interface , which should be implemented by different implementations. Signed-off-by: Amarnath Valluri <[email protected]>
Signed-off-by: Amarnath Valluri <[email protected]>
dfe6d86
to
f760cab
Compare
@okartau Now i fixed the make test failure. Can you please review. |
This change increases csi-sanity error count to 1 (was: zero):
|
looks like we return Unknown (value 2) instead of InvalidArgument (value 3) somewhere in NodeStageVolume |
we don't have explicit check for capabilities existence in NodeStageVolume handler, not before nor after this change. Seems it still returned correct code before via some side effect. I propose we add explicit check for capabilities existence |
make test is OK now! |
I think i found the issue behind this failure:
|
f760cab
to
7185764
Compare
now csi-sanity test passes with zero errors |
pkg/pmem-device-manager/pmd-lvm.go
Outdated
} | ||
volumeGroups := []string{} | ||
for _, bus := range ctx.GetBuses() { | ||
glog.Infof("CreateDevice: Bus: %v", bus.DeviceName()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, and 2 lines below, perhaps could start line with function name instead of CreateDevice: and CreateVolume. At least my initial idea with those comment was, indicate function name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will fix and resubmit
Signed-off-by: Amarnath Valluri <[email protected]>
Added new command line option 'deviceManager' to select which device manager to use for managing pmem devices, defaults to 'lvm'. Signed-off-by: Amarnath Valluri <[email protected]>
7185764
to
00d315c
Compare
These set of changes defines/implements new PmemDeviceManger interface, this hides the actual device management part from driver