This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
pmd-ndctl.go: implement FlushDeviceData #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
verified in direct-nvdimm mode, unified-mode on single host, in qemu emulation so far, running util/sanity and util/lifecycle |
avalluri
reviewed
Jan 10, 2019
|
yes, true, I think while I was testing, nullify was not working properly. |
okartau
force-pushed
the
add-flush-ndctl-mode
branch
from
7cc5f26 to
40675f5
Compare
call flushDevice on block device, this improves pass rate of csi-sanity in direct-nvdimm mode.
okartau
force-pushed
the
add-flush-ndctl-mode
branch
from
40675f5 to
52e6264
Compare
Closed
|
change from this PR was moved into #133, closing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call flushDevice on block device, this improves pass rate
of csi-sanity in direct-nvdimm mode.