Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Commit

Permalink
ndctl/region.go: comment out call to block device nullify()
Browse files Browse the repository at this point in the history
nullify() has been unreliable, so we implemented different
approach to clear device in Device Manager side.
We keep this call point for reference as commented out, just in case.
  • Loading branch information
okartau committed Jan 17, 2019
1 parent d18a83b commit 82f72a0
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/ndctl/region.go
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,12 @@ func (r *Region) DestroyNamespace(ns *Namespace, force bool) error {
return nil
}

/* originally here we try to clear 4k at start of block device,
* but that seems not work reliably so we use different method via flushDevice
* This here remains commented out
if err := ns.nullify(); err != nil {
return fmt.Errorf("failed to nullify namespace: %s", err.Error())
}
}*/

C.ndctl_namespace_disable_invalidate(ndns)

Expand Down

0 comments on commit 82f72a0

Please sign in to comment.