Fixed the compile error

[qjia7]

BUG-240

the ozone/media uses mesa header GL/gl.h. However, video.gypi didn't add it
in the include_dirs. So, that will result in 'fatal error: GL/gl.h: No such
file or directory'. Meanwhile, it will fix BUG-240

[kalyankondapally]

Can u check if it resolves #240 too.

[qjia7]

@kalyankondapally Please check the comment I added in #240. I don't know how to build your env. I tried it in linux. However, I met some error I haven't solved. So I use crosswalk for tizen as the building env. In fact, my error log is not exactly same with #240. After solving my issue, I can successfully build a crosswalk rpm package. I installed it in ivi. The mp4 video works well with hardware acceleration.

[kalyankondapally]

@qjia7 It might be due to the order of dependencies in Chromium. I myself am not sure how to fix this.

I tried this on my side and it doesn't seem to fix it. If you want to enable this for Tizen, one intermediate solution is to have this feature enabled only with use_ozone_hwa(or something meaningful) flag enabled. This would be disabled by default and only enabled with Tizen on crosswalk side. We can get rid of this once we are able to fix the compiling issue with Chromium.

[tiagovignatti]

@qjia7 I'd like to fix this for once to both Crosswalk and Chromium Browser -- I know that Chromium is not under your work scope but that's the basic platform we use in Ozone-Wayland development. So given that you're checking this problem already, the effort to correctly fix it for once for the rest of the platforms shouldn't be hard.

Thanks.

[sjnewbury]

This isn't working for me on Gentoo. I'll try to figure out why this isn't working here and provide a patch.

[sjnewbury]

@qjia7 I think my problem is due to a dependency issue. "gl" isn't getting built before the ozone media HWA component which means the gl bindings haven't been generated yet.

[sjnewbury]

@qjia7 Running "eninja -C out/Release gl eninja -C out/Release gl" first gives a successful build. So there's definitely something missing with the dependencies, but adding ui/gl to ozone/media/DEPS didn't do the trick.

[qjia7]

@sjnewbury @kalyankondapally If you run 'ninja -C out/Release wayland', is there any compile error or link error?

[sjnewbury]

@qjia7 When building the "wayland" target I get the same error as before:
In file included from ../../ozone/media/vaapi_video_decode_accelerator.h:30:0,
from ../../ozone/media/media_ozone_platform_wayland.cc:9:
../../ui/gl/gl_bindings.h:230:36: fatal error: gl_bindings_autogen_gl.h: No such file or directory
#include "gl_bindings_autogen_gl.h"
^
compilation terminated.

I'm building again with -j1 to see if a non-parallel build makes a difference.

[qjia7]

@kalyankondapally @tiagovignatti @sjnewbury Please review it again. I think this time it should fix bug-240. Moreover, this patch need to keep consistent with chromium's change (I will submit it later). Otherwise, it will cause a circle detected in the gyp. To verify it, I past the chromium's change as below: In file src/ui/gl/gl.gyp remove

-        ['use_ozone==1', {
-          'dependencies': [
-            '../ozone/ozone.gyp:ozone',
-          ],
-        }],

[tiagovignatti]

@qjia7 noupe. We obviously cannot remove that snip from src/ui/gl/gl.gyp because the gl layer explicitly depend on Ozone. This is wrong and won't be accepted upstream.

I'll start to look how to proper fix this whole thing now. I'm coming back here soon.

[sjnewbury]

@qjia7 I get a successful build with your commit as it stands now.

[tiagovignatti]

hi back. The root problem is that content/ should probably pull in the source files of Ozone-Wayland and then there wouldn't be a problem with cycling dependency. I'll talk with Chromium upstream and try to see the best way to solve that. In any case, I think we should unlock this and go with @qjia7 solution for now.

@qjia7 can you please send another pull request, adding that src/ui/gl/gl.gyp changes in a patch inside patches/ Ozone-Wayland directory?

[qjia7]

@tiagovignatti Have submitted another PR #249. Thank you.